Repository navigation
perf: hand out the cached dataset on an empty search - #116
Merged
funkadelic merged 2 commits intoOct 1, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #116 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 48 48
Lines 773 773
Branches 145 145
=========================================
Hits 773 773 ☔ View full report in Codecov by Harness. |
Contributor
Bundle ReportChanges will increase total bundle size by 11 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: yartAssets Changed:
|
Lighthouse, median of 3 mobile runs
|
funkadelic
marked this pull request as ready for review
October 1, 2026 02:37
There was a problem hiding this comment.
All reported issues were addressed across 8 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
funkadelic
deleted the
perf/share-the-cached-dataset-on-an-empty-search
branch
October 1, 2026 02:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



clearing a search reuses the sorted order already worked out instead of rechecking every row
Summary by cubic
Clearing a search now reuses the cached dataset instead of recopying every row, so the sort cache can skip its subset walk on an empty term.
getCitiesandgetFilmsnow return the frozen cached array for the empty search term instead of a copy.loadEnvelopefreezes the cached array, since callers now share it and a mutation would reorder every later caller's rows.readonlyto reflect that callers don't own a mutable array.Written for commit 236e7b4. Summary will update on new commits.