feat: initial integration with FullstoryInjector
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpanta
force-pushed
the
vasilios/rules-update
branch
from
5875554 to
10890c8
Compare
vpanta
force-pushed
the
vasilios/rules-update
branch
from
10890c8 to
40bd2a3
Compare
joshcasner
approved these changes
Dec 4, 2024
| +bzl_library( | ||
| + name = "rules", | ||
| + srcs = ["rules.bzl"], | ||
| + visibility = [ | ||
| + "//visibility:public", | ||
| + ], | ||
| + deps = [ | ||
| + "//rules:bzl", | ||
| + ":bzl", |
There was a problem hiding this comment.
Was the "providers" inclusion here what was causing the CI issue? I tried removing it earlier but that just triggered other issues
There was a problem hiding this comment.
yeah (but down in the utils definition). The issue was that while the latest unreleased rules_android has providers/providers.bzl, as of this release the file is still under rules/providers.bzl, so the deps in the patch was bad.
|
Also d'oh! The need for the local repo is causing CI to fail. That's not really surprise. I'm going to merge this for now as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update allows folks to use the Fullstory ruleset if we have provided them with a pre-release version of our Maven repository (and they have it installed locally).