fix(reusable-fix): propagate gh pr view failures in eligibility check#1565
Open
rh-hemartin wants to merge 1 commit into
Open
fix(reusable-fix): propagate gh pr view failures in eligibility check#1565rh-hemartin wants to merge 1 commit into
rh-hemartin wants to merge 1 commit into
Conversation
Silent fallback `|| echo '{"labels":[],"author":""}')` was masking API
errors and causing false "human-authored PR" rejections when `gh pr view`
failed. Remove the fallback so errors surface explicitly.
Closes #1564
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Hector Martinez <hemartin@redhat.com>
Site previewPreview: https://94077440-site.fullsend-ai.workers.dev Commit: |
ReviewFindingsMedium
Info
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gh pr viewin the "Check fix eligibility" step was called with2>/dev/null || echo '{"labels":[],"author":""}', silently swallowing API failures::error::and exits 1 explicitlyCloses #1564
Test plan
gh pr viewfailure (e.g. revoke token) and confirm the job fails with::error::Failed to fetch PR inforather than the misleading "human-authored" message🤖 Generated with Claude Code