Skip to content

fix(reusable-fix): propagate gh pr view failures in eligibility check#1565

Open
rh-hemartin wants to merge 1 commit into
mainfrom
fix/reusable-fix-eligibility-error-propagation
Open

fix(reusable-fix): propagate gh pr view failures in eligibility check#1565
rh-hemartin wants to merge 1 commit into
mainfrom
fix/reusable-fix-eligibility-error-propagation

Conversation

@rh-hemartin
Copy link
Copy Markdown
Contributor

Summary

  • gh pr view in the "Check fix eligibility" step was called with 2>/dev/null || echo '{"labels":[],"author":""}', silently swallowing API failures
  • A failed call returned empty author/labels, causing the step to exit 1 with a misleading "Human-authored PR without fullsend-fix label" message instead of exposing the real error
  • Removes the silent fallback; failure now emits ::error:: and exits 1 explicitly

Closes #1564

Test plan

  • Verify the eligibility step passes normally on a bot-triggered PR with expected labels
  • Simulate a gh pr view failure (e.g. revoke token) and confirm the job fails with ::error::Failed to fetch PR info rather than the misleading "human-authored" message

🤖 Generated with Claude Code

Silent fallback `|| echo '{"labels":[],"author":""}')` was masking API
errors and causing false "human-authored PR" rejections when `gh pr view`
failed. Remove the fallback so errors surface explicitly.

Closes #1564

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Hector Martinez <hemartin@redhat.com>
@github-actions
Copy link
Copy Markdown

Site preview

Preview: https://94077440-site.fullsend-ai.workers.dev

Commit: d969b5675d1a3a20305e6fcc7a8ed6111fa5e2b9

@fullsend-ai-review
Copy link
Copy Markdown

Review

Findings

Medium

Info

  • [style-consistency] .github/workflows/reusable-fix.yml:250 — The new error handling pattern (|| { echo "::error::..."; exit 1; }) is consistent with similar patterns elsewhere in this workflow (e.g., the fix-commit counting step uses || { echo "::warning::..."; ... }). The escalation from ::warning:: (soft failure with fallback) to ::error:: (hard failure) is appropriate here since eligibility is a gate, not a best-effort count. No action needed.

@fullsend-ai-review fullsend-ai-review Bot added the requires-manual-review Review requires human judgment label May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires-manual-review Review requires human judgment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

reusable-fix: gh pr view failure silently bypasses fix eligibility check

1 participant