fix(skills): satisfy ty check in analyze-transcript#1436
Open
ifireball wants to merge 1 commit into
Open
Conversation
Site previewPreview: https://1831dfb4-site.fullsend-ai.workers.dev Commit: |
ReviewFindingsNo findings. Previous runReviewFindingsNo findings. |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
the
ready-for-merge
Add ToolStats TypedDict so ty can infer count/lines types, and pin mise Go to 1.26.0 to match go.mod so local make test does not hit toolchain skew. Co-authored-by: Cursor <[email protected]> Signed-off-by: Barak Korren <[email protected]> Co-authored-by: Cursor <[email protected]>
ifireball
force-pushed
the
fix/analyze-transcript-ty-check
branch
from
726ab9a to
b6c4da8
Compare
fullsend-ai-review
Bot
removed
the
ready-for-merge
fullsend-ai-review
Bot
added
the
ready-for-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToolStatsTypedDictand annotatetool_dataincmd_toolssotycan infercountandlinestypes (fixes four diagnostics that failmake test/ pre-committy checkon current main with recenttyreleases).1.25.8to1.26.0to matchgo.mod, avoidingcompile: version "go1.26.0" does not match go tool version "go1.25.8"whenGOTOOLCHAIN=autois set in the Makefile.No existing open PR addressed these failures.
Test plan
make test(aftermise trust,mise install, anduv pip install --system jsonschemaper CI)lint.ymlon this PRMade with Cursor