Loosen source_gen and build version constraints. #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankenApps
force-pushed
the
loosen-deps-constraints
branch
from
2373fdf to
36cdb94
Compare
fujidaiti
approved these changes
Oct 13, 2025
Owner
fujidaiti
left a comment
fujidaiti
left a comment
There was a problem hiding this comment.
Thank you again for your contribution!
As far as I can tell, this shouldn't be a breaking change, therefore bumping the version to 1.6.1 would be enough in case only this PR would be included in the next release.
Yes, I will release this patch as v1.6.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
This change is once again inspired by a PR made to
json_serializable.I've had to silence some occurrences of the
deprecated_member_uselint in order to maintain compatibility withbuildversion3.xandsource_genversion3.x. Once we are ready to force downstream users to use versions4.x, the deprecated members can be replaced by their actual replacements (for exampleElement2back toElementas outlined in the element model migration guide of theanalyzerpackage).As far as I can tell, this shouldn't be a breaking change, therefore bumping the version to
1.6.1would be enough in case only this PR would be included in the next release.Let's hope that the dust around these
build_runnerrelated major version changes settles soon, so I don't have to continue making these PRs ;)