Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps, add php-cs-fix config #56

Merged
merged 5 commits into from
Jan 8, 2025
Merged

Update deps, add php-cs-fix config #56

merged 5 commits into from
Jan 8, 2025

Conversation

thejmitchener
Copy link
Member

@thejmitchener thejmitchener commented Jan 8, 2025

Pull Request Description: Update deps, add php-cs-fix config

This pull request introduces several important updates to our project, aimed at improving code quality and maintainability.

Motivation:

  1. Dependency Update: The addition of spatie/crawler (version ^8.4.0) enhances our project's capabilities, providing better tools for web crawling. This aligns with our goal to keep dependencies up-to-date and leverage the latest features and improvements.

  2. PHP-CS-Fixer Configuration: A new configuration file for PHP-CS-Fixer has been added, along with a cache file. This will enforce consistent coding standards across the codebase, which is essential for maintaining readability and reducing bugs. The rules set in this configuration are designed to align with modern PHP practices, ensuring our code adheres to standards such as PSR-2.

  3. Code Cleanliness: Minor adjustments have been made throughout various files, including reformatting and organizing code to comply with the new coding standards. This not only improves the overall structure of the code but also ensures that future contributions will be easier to integrate.

Benefits:

  • Improved Code Quality: By enforcing coding standards, we reduce the likelihood of introducing errors and improve the overall quality of our code.
  • Easier Maintenance: Consistency in code style makes it easier for developers to read and understand the code, facilitating smoother collaboration.
  • Up-to-date Dependencies: Keeping our dependencies current reduces security vulnerabilities and ensures compatibility with the latest features and improvements.

In summary, this pull request enhances our project's maintainability and quality by updating dependencies and implementing a PHP-CS-Fixer configuration. These changes will lay a stronger foundation for future development and collaboration.

thejmitchener and others added 5 commits January 8, 2025 15:12
… ignore certain paths and files. Updated composer.json to include the spatie/crawler package as a dependency.
…e to improve the organization of the project and to exclude unnecessary files from version control.
@thejmitchener thejmitchener merged commit b5aad5f into main Jan 8, 2025
8 checks passed
@thejmitchener thejmitchener deleted the update-deps branch January 8, 2025 20:17
fuelviews-app bot pushed a commit that referenced this pull request Jan 8, 2025
* Added .php-cs-fixer.dist.php file to configure PHP-CS-Fixer rules and ignore certain paths and files. Updated composer.json to include the spatie/crawler package as a dependency.

* Fix styling

* Fix styling

* Renamed the file  to  and removed  from the  file. These changes were made to improve the organization of the project and to exclude unnecessary files from version control.

---------

Co-authored-by: thejmitchener <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant