Refactored the GitHub workflow to run only if the actor is not Dependabot. Updated the return type of the method in the class to use the constants for success and failure. #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces two significant improvements to the project.
First, it refines the GitHub Actions workflow by adding a condition to ensure that the workflow only runs if the actor is not Dependabot. This change prevents unnecessary workflow executions triggered by Dependabot, optimizing our CI/CD process and reducing clutter in our workflow logs.
Second, it updates the return type of the
handle
method in theSitemapGenerateCommand
class frombool
toint
. This change aligns the method's return values with the Symfony Console Component's conventions, using constants for success and failure. By returningCommand::SUCCESS
andCommand::FAILURE
, we enhance code clarity and ensure better integration with Symfony's command handling, which improves maintainability and consistency across the codebase.Overall, these changes improve the efficiency of our CI/CD pipeline and enhance the robustness of our command handling logic.