Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored the GitHub workflow to run only if the actor is not Dependabot. Updated the return type of the method in the class to use the constants for success and failure. #46

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

thejmitchener
Copy link
Member

@thejmitchener thejmitchener commented Dec 18, 2024

Introduces two significant improvements to the project.

First, it refines the GitHub Actions workflow by adding a condition to ensure that the workflow only runs if the actor is not Dependabot. This change prevents unnecessary workflow executions triggered by Dependabot, optimizing our CI/CD process and reducing clutter in our workflow logs.

Second, it updates the return type of the handle method in the SitemapGenerateCommand class from bool to int. This change aligns the method's return values with the Symfony Console Component's conventions, using constants for success and failure. By returning Command::SUCCESS and Command::FAILURE, we enhance code clarity and ensure better integration with Symfony's command handling, which improves maintainability and consistency across the codebase.

Overall, these changes improve the efficiency of our CI/CD pipeline and enhance the robustness of our command handling logic.

thejmitchener and others added 2 commits December 18, 2024 12:39
…abot. Updated the return type of the method in the class to use the constants for success and failure.
@thejmitchener thejmitchener reopened this Dec 18, 2024
@thejmitchener thejmitchener merged commit ad43985 into main Dec 18, 2024
8 checks passed
@thejmitchener thejmitchener deleted the update-command-return branch December 18, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant