Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor sitemap generation and linking functionality. The changes were made to improve the flexibility and reusability of the code, allowing for dynamic sitemap filenames and routes. #14

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

thejmitchener
Copy link
Member

@thejmitchener thejmitchener commented Jul 7, 2024

Focuses on refactoring the sitemap generation and linking functionality to improve flexibility and reusability of the code. The changes allow for dynamic sitemap filenames and routes, enhancing the overall usability of the sitemap feature.

Specifically, the changes in the code include:

  • Updating the README.md file to include instructions on linking to the sitemap with dynamic filenames.
  • Refactoring the SitemapController.php to remove the hardcoded default filename and make the filename parameter required for better flexibility.
  • Modifying the SitemapServiceProvider.php to adjust the route definition to accept dynamic filenames and ensure they end with ".xml".

These changes enhance the codebase by making the sitemap generation and linking functionality more adaptable and reusable, ultimately improving the project's maintainability and efficiency.

…re made to improve the flexibility and reusability of the code, allowing for dynamic sitemap filenames and routes.
@thejmitchener thejmitchener merged commit eeba5bb into main Jul 7, 2024
11 checks passed
@thejmitchener thejmitchener deleted the revert-update-update-readme branch July 7, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant