Refactor SitemapController and SitemapServiceProvider to allow for default sitemap file name and update the route to only accept requests for the specific sitemap.xml file. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…default sitemap file name and update the route to only accept requests for the specific sitemap.xml file.
Bumps [laravel/pint](https://github.com/laravel/pint) from 1.16.0 to 1.16.1. - [Release notes](https://github.com/laravel/pint/releases) - [Changelog](https://github.com/laravel/pint/blob/main/CHANGELOG.md) - [Commits](laravel/pint@v1.16.0...v1.16.1) --- updated-dependencies: - dependency-name: laravel/pint dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Joshua Mitchener <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the SitemapController and SitemapServiceProvider to enhance the handling of sitemap files.
In SitemapController.php, the
__invokemethod now accepts a nullable$filenameparameter, with a default value of 'sitemap.xml'. This change allows for a default sitemap file name to be used if no specific filename is provided.In SitemapServiceProvider.php, the route configuration has been updated to only accept requests for the specific 'sitemap.xml' file. This restricts the route to handle requests for the sitemap.xml file exclusively, ensuring a more focused and secure routing for sitemap requests.
These changes improve the flexibility and security of the sitemap functionality, providing a more robust and efficient handling of sitemap files within the project.