[Don't Merge] Benchmarks #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attached run log so you could see exceptions. Waiting for your suggestions on benchmarks. Maybe add some other libraries to compare? |
|
Thank you for doing this!
First thing to note: performance has never been priority for me while
writing FSharp.Json. This does not mean I made it slow intentionally, I
just never concentrated on it. Main focus was on strong type consistency:
correct null-safety support, better unions support.
Main reason of slowness (you are right) is in the slow backend which is
JsonValue. JsonValue looked as convenient intermediate layer between
raw data and F# structures: string (or byte array) -> JsonValue -> F#
structures. JsonValue provided me some luxury in FSharp.Json source code,
though this convenience came with performance penalty. Newtonsoft.Json is
using simplest tokenizer under the hood and that's why it's faster.
Switching backend is plenty of work and I think I will need to do it at
some point. Especially for leveraging new Span type. Though FSharp.Json
wasn't designed with swappable backend in mind and as I mentioned
JsonValue is bigger then just tokenizer. So this is not easy. Also
regarding backends made in C# (like Utf8Json): I strongly believe in zero
transitive dependencies approach for such core libraries as JSON
serialization. Internalizing C# code into F# project is not possible as I
know. There are some workarounds but they are not as beautiful as
internalized code to my taste.
…On Mon, Apr 29, 2019, 04:18 Daniil Barbashov ***@***.***> wrote:
Attached run log so you could see exceptions. Waiting for your suggestions
on benchmarks. Maybe add some other libraries to compare?
BenchmarkRun-20190429-105157.log
<https://github.com/vsapronov/FSharp.Json/files/3126473/BenchmarkRun-20190429-105157.log>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#23 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGYLNR4KPDJ5PWBACAAYPTPS2VM3ANCNFSM4HJBGP6Q>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've adopted Benchmark project from FsPickler. There are some benchmarks that you may find interesting. Some benchmarks fail because of lack of support. Here are results:
FSharp.Json.Benchmarks.Array3D.Array3DRoundtrip
Benchmarks with issues:
Array3DRoundtrip.FSharp.Json: DefaultJob
FSharp.Json.Benchmarks.BoxedArray.BoxedArrayRoundtrip
FSharp.Json.Benchmarks.Dictionary.DictionaryRoundtrip
Benchmarks with issues:
DictionaryRoundtrip.FSharp.Json: DefaultJob
FSharp.Json.Benchmarks.ExceptionBench.ExceptionRoundtrip
Benchmarks with issues:
ExceptionRoundtrip.FSharp.Json: DefaultJob
FSharp.Json.Benchmarks.FloatArray.FloatArrayRoundtrip
Benchmarks with issues:
FloatArrayRoundtrip.FSharp.Json: DefaultJob
FSharp.Json.Benchmarks.FSharpBinTree.FSharpBinaryRoundtrip
FSharp.Json.Benchmarks.FSharpList.FSharpListRoundtrip
FSharp.Json.Benchmarks.FSharpMap.FSharpMapRountrip
FSharp.Json.Benchmarks.FSharpSet.FSharpSetRoundtrip
Benchmarks with issues:
FSharpSetRoundtrip.FSharp.Json: DefaultJob
FSharp.Json.Benchmarks.ISerializable.ISerializableRoundtrip
Benchmarks with issues:
ISerializableRoundtrip.FSharp.Json: DefaultJob
FSharp.Json.Benchmarks.LargeObject.LargeFSharpValueRoundtrip
Benchmarks with issues:
LargeFSharpValueRoundtrip.FSharp.Json: DefaultJob
FSharp.Json.Benchmarks.LargeTuple.LargeTupleRoundtrip
FSharp.Json.Benchmarks.MemberInfo.MemberInfoRoundtrip
Benchmarks with issues:
MemberInfoRoundtrip.Newtonsoft.Json: DefaultJob
MemberInfoRoundtrip.FSharp.Json: DefaultJob
FSharp.Json.Benchmarks.Poco.PocoRoundtrip
Benchmarks with issues:
PocoRoundtrip.FSharp.Json: DefaultJob