Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests to .NET 8 #1516

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Update tests to .NET 8 #1516

merged 4 commits into from
Oct 2, 2024

Conversation

Thorium
Copy link
Member

@Thorium Thorium commented Sep 27, 2024 •
edited
Loading

This updates:

  • Fake and Paket to latest versions
  • Globals.js to build on .NET 8
  • Test projects from .NET 6 to .NET 8
  • Also build-fixes included what are needed:
    • WorldBank to https
    • Document generation fix on data source of F1 Season_Calendar
  • CI-machine script updated (force-push over few trials)

pkese
pkese approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@pkese pkese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pkese pkese mentioned this pull request Oct 1, 2024
Closed
@dsyme dsyme merged commit 992bd09 into fsprojects:main Oct 2, 2024
2 checks passed
@dsyme
Copy link
Contributor

dsyme commented Oct 2, 2024

@pkese @Thorium Great work! Would you like to become co-maintainer?

@Thorium
Copy link
Member Author

Thorium commented Oct 2, 2024

I guess I’m not too busy, if you think it would help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkese pkese pkese approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Thorium @dsyme @pkese