[Draft] Fix resumable upload

[barathsriram]

This is a work-in-progress PR that intends to fix #532 and #623

Changes:

1. Fix the Resumable upload URL to match Google's API URL
2. Retrieve upload_id from query parameter

TODO:

• Fix any existing test failures
• Add new tests for the changes

[agates4]

Awesome, thanks for putting this together. I'm looking forward to it!

[fsouza]

Hey @barathsriram, thanks for contributing! Do you plan to continue working on this?

[barathsriram]

Hey @fsouza apologies for the delay in response. Yes, I am planning to start the work again on this PR soon.

[wwwjn]

Hey @barathsriram thanks for such great work! Is there any progress on this PR?

[ciekawy]

considering node library @google-cloud/storage does seem to use resumable uploads only - am I correct this feature is correctly broken?

[rockettomatooo]

I am also using the node @google-cloud/storage package. Would love to see this PR merged! 🤩

[fsouza]

considering node library @google-cloud/storage does seem to use resumable uploads only - am I correct this feature is correctly broken?

I think there are multiple endpoints for resumable uploads and the node library uses one that's not supported by fake-gcs-server. I don't know exactly whether this PR fixes that issue as I haven't encountered it myself, but I do plan to pick it back some time before the end of May if @barathsriram doesn't beat me to it.

[odinho]

To make this turn up on search, I believe this is the error we're getting when we try to use @google-cloud/storage nodejs package:

172.30.0.15 - - [11/Oct/2023:09:12:31 +0000] \"PATCH /b/bucket/o/folder%2file.json? HTTP/1.1\" 405 0\n"

Error: Call  falied  [cause]: ApiError: Method Not Allowed   at <my code>
   at new ApiError (/cloud-function/node_modules/@google-cloud/storage/build/src/nodejs-common/util.js:79:15)
      at Util.parseHttpRespMessage (/cloud-function/node_modules/@google-cloud/storage/build/src/nodejs-common/util.js:181:41)
      at Util.handleResp (/cloud-function/node_modules/@google-cloud/storage/build/src/nodejs-common/util.js:155:76)
      at /cloud-function/node_modules/@google-cloud/storage/build/src/nodejs-common/util.js:537:22
      at onResponse (/cloud-function/node_modules/retry-request/index.js:240:7)
      at /cloud-function/node_modules/teeny-request/build/src/index.js:226:13
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
    code: 405,
    errors: [],
    response: PassThrough {
      _readableState: [ReadableState],
      _events: [Object: null prototype],
      _eventsCount: 4,
      _maxListeners: undefined,
      _writableState: [WritableState],
      allowHalfOpen: true,
      statusCode: 405,
      statusMessage: 'Method Not Allowed',
      request: [Object],
      body: '',
      headers: [Object],
      toJSON: [Function: toJSON],
      [Symbol(kCapture)]: false,
      [Symbol(kCallback)]: null
    }
  }

Basically, the PATCH request returns a 405 Method Not Allowed in some cases of the resumable upload.

---

Seeing as this new PR doesn't really start supporting PATCH at all, it's something else. This code was using file.setMetadata({metadata: { changeCount: 1 }}), so that probably sends a PATCH.