Fix: fixed range exception problem for PgNumeric2BCD procedure #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… digits, rewritten procedure without using goto, added comments on procedure steps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in the previous procedure is very fast but have a problem with high precision numeric, a PostgreSQL query like:
SELECT 1.22222222222222222222222222222222222222222222222222222222222222222 AS value
would trigger a Range Check Error, and then the application freeze.
I tested the application compiled using Lazarus with Zeos 8.0.0 on both Manjaro Linux and Windows.
The procedure has been revised, the gotos have been cleaned up, limit the decimal output to 64 digits and comments have been inserted in the various steps.
ref:
https://zeoslib.sourceforge.io/viewtopic.php?t=250601