Install app icon in XDG hicolor icon theme#3831
Open
pinotree wants to merge 1 commit intofritzing:developfrom
Open
Install app icon in XDG hicolor icon theme#3831pinotree wants to merge 1 commit intofritzing:developfrom
pinotree wants to merge 1 commit intofritzing:developfrom
Conversation
pinotree
force-pushed
the
icon-in-hicolor
branch
from
1362a06 to
1f42b5e
Compare
Install the icon of the application in the hicolor XDG icon theme; this way it can be properly loaded by XDG menus in the currently set XDG icon theme, without looking in the legacy pixmaps location.
Author
|
@KjellMorgenstern PTAL :) |
|
Member
|
Reading into this here https://doc.qt.io/qt-6/appicon.html first gave me the impression that the pixmap directory is used mostly for gnome, while the icons directory is used on kde. https://specifications.freedesktop.org/icon-theme-spec/0.13/#install_icons suggests to use further subdirectories for the theme, like in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install the icon of the application in the hicolor XDG icon theme; this way it can be properly loaded by XDG menus in the currently set XDG icon theme, without looking in the legacy pixmaps location.