Module: always ref on construct

frida · Jan 15, 2025 · 8586544 · 8586544
1 parent 588381c
commit 8586544
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/frida-gum/src/module.rs b/frida-gum/src/module.rs
@@ -93,6 +93,9 @@ pub struct Module {
 
 impl Module {
     pub(crate) fn from_raw(module: *mut GumModule) -> Self {
+        unsafe {
+            gum_sys::g_object_ref(module.cast());
+        }
         Self { inner: module }
     }
     /// Load a module by name

diff --git a/frida-gum/src/process.rs b/frida-gum/src/process.rs
@@ -207,7 +207,6 @@ impl<'a> Process<'a> {
             user_data: gpointer,
         ) -> gboolean {
             let res = &mut *(user_data as *mut CallbackData);
-            gum_sys::g_object_ref(details.cast());
             res.modules.push(Module::from_raw(details));
 
             1