fix: watch.Filter panic with kooper v2.10 / client-go v0.35#64
Closed
Conversation
Signed-off-by: Sasidharan3094 <sasidharan.gopal94@gmail.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [azure/setup-helm](https://github.com/azure/setup-helm) from 4 to 5. - [Release notes](https://github.com/azure/setup-helm/releases) - [Changelog](https://github.com/Azure/setup-helm/blob/main/CHANGELOG.md) - [Commits](Azure/setup-helm@v4...v5) --- updated-dependencies: - dependency-name: azure/setup-helm dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Return the API watch error before wrapping with watch.Filter so a nil watcher cannot panic the informer. Opt out of client-go WatchList semantics for the custom ListWatch and add context-aware list/watch funcs for compatibility with client-go v0.35+ and the kooper dependency bump.
Bumps [github.com/spotahome/kooper/v2](https://github.com/spotahome/kooper) from 2.5.0 to 2.10.0. - [Release notes](https://github.com/spotahome/kooper/releases) - [Changelog](https://github.com/spotahome/kooper/blob/master/CHANGELOG.md) - [Commits](spotahome/kooper@v2.5.0...v2.10.0) --- updated-dependencies: - dependency-name: github.com/spotahome/kooper/v2 dependency-version: 2.10.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Kaushik-Vijayakumar
requested review from
Kaushik-Vijayakumar-1,
Sasidharan-Gopal and
pratheep-kumar
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the integration test panic seen when merging dependabot PR #59 (kooper v2.5.0 → v2.10.0, k8s client-go v0.35).
watch.Filter(avoids nil-pointer infilteredWatch.loop).IsWatchListSemanticsUnSupported).ListWithContextFunc/WatchFuncWithContextfor client-go v0.35 reflectors.Includes the same
go.mod/go.sumchanges as Bump github.com/spotahome/kooper/v2 from 2.5.0 to 2.10.0 #59.Related
Test plan
make ci-unit-testandmake ci-lintpass