modal submit disabled fix#188
Open
mallikarjun1234 wants to merge 1 commit into
Open
Conversation
modal submit disabled fix
|
Deploy preview for freshworks-nucleus processing. Building with commit ebf6c9e https://app.netlify.com/sites/freshworks-nucleus/deploys/5ec555766c920900065678ee |
rajasegar-c
approved these changes
May 21, 2020
| { | ||
| "name": "@freshworks/modal", | ||
| "version": "0.6.6", | ||
| "version": "0.6.7", |
Contributor
There was a problem hiding this comment.
We need not specify the versions explicitly anywhere. Release will be taken care during deployment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submit disabled value is not passed from modal component to button component, Hence we are are not able to disable the submit button. Fixing that by just passing the value to button component.