Support pylint 4 #458
Support pylint 4 #458
Conversation
Signed-off-by: Mathias L. Baumann <[email protected]>
Marenz
requested review from
Copilot and
llucax
and removed request for
Copilot
github-actions
bot
added
the
part:tooling
god damn f.. |
Signed-off-by: Leandro Lucarella <[email protected]>
github-actions
bot
added
the
part:template
There was a problem hiding this comment.
Pull Request Overview
Supports pylint 4 by widening the upper bound and updating dependency pins; also broad dependency bumps across cookiecutter templates and golden test fixtures.
- Widened pylint constraint to <5 in root config and pinned dev environment to 4.0.0
- Updated numerous dependency versions (frequenz-sdk, protobuf/grpc, mkdocs-related, typing-extensions, etc.)
- Added a generic release note entry for dependency updates
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests_golden/.../model/.../pyproject.toml | Updated dependency and tooling versions for model template fixture |
| tests_golden/.../lib/.../pyproject.toml | Updated dependency and tooling versions for lib template fixture |
| tests_golden/.../app/.../pyproject.toml | Updated dependency and tooling versions for app template fixture |
| tests_golden/.../api/.../pyproject.toml | Updated dependency and tooling versions incl. protobuf/grpc ranges for api template fixture |
| tests_golden/.../actor/.../pyproject.toml | Updated dependency and tooling versions for actor template fixture |
| pyproject.toml | Widened pylint upper bound and pinned dev-pytest env to pylint 4.0.0 |
| cookiecutter/{{cookiecutter.github_repo_name}}/pyproject.toml | Updated template dependency versions (SDK, protobuf/grpc, tooling) but left pylint at 3.3.8 |
| RELEASE_NOTES.md | Added a generic bullet about dependency updates |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| "pytest == 8.3.4", | ||
| "pylint == 3.3.4", # We need this to check for the examples | ||
| "pytest == 8.4.1", | ||
| "pylint == 3.3.8", # We need this to check for the examples |
There was a problem hiding this comment.
The root project now allows pylint <5 and pins 4.0.0, but the template still pins 3.3.8, creating an inconsistency that will cause newly generated projects to lag behind the supported major version. Either bump this pin to 4.0.0 (or a compatible >= constraint within <5) or document why templates intentionally remain on 3.3.8; also update the golden test fixtures accordingly after adjusting.
| "pylint == 3.3.8", # We need this to check for the examples | |
| "pylint == 4.0.0", # We need this to check for the examples |
Copilot uses AI. Check for mistakes.
| ### Cookiecutter template | ||
|
|
||
| <!-- Here new features for cookiecutter specifically --> | ||
| - Dependencies have been updated. |
There was a problem hiding this comment.
This release note is too generic; specify key impactful changes (e.g., support for pylint 4 by widening the upper bound, protobuf range widened to <8, grpcio minimum bump, SDK version range updates) so consumers understand potential upgrade considerations.
| - Dependencies have been updated. | |
| - Dependency updates: | |
| - Widened `pylint` upper bound to support v4. | |
| - Widened `protobuf` version range to `<8`. | |
| - Bumped minimum `grpcio` version. | |
| - Updated SDK version range. |
Copilot uses AI. Check for mistakes.
RELEASE_NOTES.md
Outdated
|
|
||
| ## New Features | ||
|
|
||
| <!-- Here goes the main new features and examples or instructions on how to use them --> |
There was a problem hiding this comment.
Maybe announcing support for pylint 4 here?
Signed-off-by: Mathias L. Baumann <[email protected]>
2 participants
previous fix was merged to main branch instead of version branch