Add assets config to microgrid config #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyiallou
reviewed
Jan 22, 2025
src/frequenz/lib/notebooks/config.py
Outdated
Comment on lines
164
to
171
| self._assets_cfg = AssetsConfig( | ||
| pv=config_dict.get("pv") or {}, | ||
| ) |
There was a problem hiding this comment.
Is there a specific reason for only including pv for now?
I suggest updating the __init__ method to initialize _assets_cfg with configurations for all three asset types. This would make the behaviour consistent with the AssetsConfig design.
There was a problem hiding this comment.
Good point, will update
Config files specifying assets pv, wind and battery are now supported and asset metadata can be accessed via the `assets` property. For each asset type multiple entries can be specified in dict form. Signed-off-by: cwasicki <[email protected]>
|
Updated. |
cyiallou
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config files specifying assets pv, wind and battery are now supported and asset metadata can be accessed via the
assetsproperty. For each asset type multiple entries can be specified in dict form.