Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flakey tests #99

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Fix flakey tests #99

merged 2 commits into from
Jan 22, 2025

Conversation

Marenz
Copy link
Contributor

@Marenz Marenz commented Jan 21, 2025

  • Fix test_env in test that re-created it
  • Use dispatch-client version with flakey-tests fix

@Marenz Marenz requested a review from a team as a code owner January 21, 2025 18:11
@github-actions github-actions bot added part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) part:dispatcher Affects the high-level dispatcher interface labels Jan 21, 2025
@Marenz
Copy link
Contributor Author

Marenz commented Jan 21, 2025

Depends on frequenz-floss/frequenz-client-dispatch-python#124

@Marenz Marenz force-pushed the no-flake branch 2 times, most recently from 7cc0bb9 to a69c2e4 Compare January 22, 2025 16:00
Marenz added 2 commits January 22, 2025 17:06
@Marenz
Fix test_env in test that re-created it
31bd582 
This particular test restarted the background dispatch service, which
means all receivers were invalidated and had to be recreated.

Signed-off-by: Mathias L. Baumann <[email protected]>
@Marenz
Use dispatch-client version with flakey-tests fix
30b99e1 
Signed-off-by: Mathias L. Baumann <[email protected]>
@Marenz Marenz enabled auto-merge January 22, 2025 16:31
@Marenz Marenz mentioned this pull request Jan 22, 2025
Merged
llucax
llucax approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@llucax llucax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't exactly what was wrong and how it was fixed for the test, but I'll trust you so approving.

@Marenz Marenz added this pull request to the merge queue Jan 22, 2025
Merged via the queue into frequenz-floss:v0.x.x with commit 4d24320 Jan 22, 2025
14 checks passed
@Marenz Marenz deleted the no-flake branch January 22, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llucax llucax llucax approved these changes

@stefan-brus-frequenz stefan-brus-frequenz Awaiting requested review from stefan-brus-frequenz stefan-brus-frequenz is a code owner automatically assigned from frequenz-floss/api-dispatch-team

Assignees
No one assigned
Labels
part:dispatcher Affects the high-level dispatcher interface part:tests Affects the unit, integration and performance (benchmarks) tests part:tooling Affects the development tooling (CI, deployment, dependency management, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Marenz @llucax