-
Notifications
You must be signed in to change notification settings - Fork 12
Add a newcomer tutorial #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v0.x.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new "Tutorials" documentation section with a comprehensive newcomer tutorial designed for users with no Python experience. The tutorial covers the complete setup process from installing VS Code to creating API keys and initializing the client.
- Adds a newcomer tutorial covering environment setup, API key creation, and client initialization
- Updates documentation configuration to support GitHub-style callouts
- Reformats code style in pyproject.toml for consistency
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
docs/tutorials/newcomer.md | New comprehensive tutorial for Python newcomers with step-by-step setup instructions |
docs/SUMMARY.md | Adds Tutorials section to documentation navigation |
README.md | Adds reference to newcomer tutorial with helpful callout |
mkdocs.yml | Enables github-callouts markdown extension for enhanced documentation |
pyproject.toml | Reformats dependencies and keywords for better readability, adds markdown-callouts package |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Leandro Lucarella <[email protected]>
932e9c4
to
4f69b6f
Compare
Replaces #219, as agreed with @merlin-esser-frequenz. |
This commit adds a new "Tutorials" documentation section, including a new tutorial for newcomers with no Python experience. Co-authored-by: merlin-esser-frequenz <[email protected]> Signed-off-by: Leandro Lucarella <[email protected]>
This extension allows using a GitHub compatible admonitions syntax, so admonitions can also be rendered nicely when the markdown file is rendered by GitHub. Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
4f69b6f
to
c53f445
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, my suggestion was that most of the original tutorial was OK, it was just not something to put in the README. This PR does that, moves the instructions to a dedicated "Tutorial for newcomers", where I think it makes sense to give very opinionated instructions and even suggestions on how to use it to build notebooks, etc. Since nobody opposed to this suggestion (Tom was the only one to react to it and he did with a 👍) and the PR seemed stalled, I decided to push for it myself so Merlin's work doesn't go to waste, as again I think it is very useful to introduce non (Python) programmers on how to use the reporting API. So I guess we have a couple of high-level questions here:
In general I think merging this in this repo is a step forward, and we can build on top of it instead of not merging anything until it is perfect, but I'm also opened to alternatives. |
There are various issues in these docs, including bugs. All discussed in the old PR.
At least we would need to provide a link to a guide like this. If we want to maintain it also, I would expect that the commands can be copy-pasted by people without dev background and work out-of-the box on almost all machines.
You suggested https://github.com/frequenz-floss/docs/, that sounds like a good idea.
I would strongly vote for this. To me there are the following main parts:
|
* Remove pandas as it is not used in the examples, we can add it back if we add some pandas examples in the guide in the future. * Fix typo in ipykernel installation command.
I went again through all the comments and I found only 2 bugs I missed when redoing the PR ( All other comments are about stuff not being appropriate for the README (which is addressed by this PR), about being too opinionated and suggesting more stuff than what is strictly necessary to use this library (which is also addressed in this PR by making it a newcomer's guide, which says explicitly it is opinionated as the goal is to introduce outsiders, not to be neutral for seasoned developers), and about splitting common parts that could apply to many other open source projects and move that to If there are more issue, please point them out individually, as I couldn't find any others.
Me too, but there is a bandwidth problem. I did this PR because it was a low-hanging fruit and I thought it brings value (i.e. the point we are at with this PR merged is better than the point we are without this PR merged, which doesn't mean it is the point where we really want to be long term). |
This PR adds a new "Tutorials" documentation section, including a new tutorial for newcomers with no Python experience.