Switch to the new version of jacogr/polkadot-js-tools #1594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilwade
force-pushed
the
chore/update-comp-metadata-docker-1230
branch
3 times, most recently
from
e13b7e5 to
e2b5862
Compare
wilwade
force-pushed
the
chore/update-comp-metadata-docker-1230
branch
from
e2b5862 to
c591bcb
Compare
Tested with: docker run --platform=linux/amd64 --pull always --network host jacogr/polkadot-js-tools:0.55.3 metadata wss://1.rpc.frequency.xyz wss://rpc.rococo.frequency.xyz
Working dir Fix bin dir
wilwade
force-pushed
the
chore/update-comp-metadata-docker-1230
branch
from
f2fbf5d to
c94a44d
Compare
demisx
reviewed
Jun 15, 2023
| @@ -517,40 +526,48 @@ jobs: | |||
| run: | | |||
| chmod 755 $TEST_BIN_FILENAME | |||
| chmod 755 $REF_BIN_FILENAME | |||
| - name: Docker network | |||
| run: docker network create net-${{env.RELEASE_BRANCH_NAME}} | |||
There was a problem hiding this comment.
Pretty slick. I like this idea. Wondering if this approach may help us to resolve running docker in docker issues... 🤔
rlaferla
reviewed
Jun 15, 2023
| @@ -153,7 +155,8 @@ jobs: | |||
| matrix: | |||
| # This job intermittently fails on EKS runners and must be run on standalone until | |||
| # https://www.pivotaltracker.com/story/show/185045683 is resolved. | |||
| os: [[self-hosted, Linux, X64, build]] | |||
| # os: [[self-hosted, Linux, X64, testing, v2], [self-hosted, Linux, ARM64, testing, v2]] | |||
| os: [[self-hosted, Linux, X64, testing, v2]] | |||
There was a problem hiding this comment.
What is the purpose of "testing" and "v2"?
There was a problem hiding this comment.
These are the new eks runners.
rlaferla
reviewed
Jun 15, 2023
| run: | | ||
| CMD="docker run --pull always --network host frequencychain/polkadot-js-tools:v0.52.29 metadata ws://localhost:9946 ws://localhost:9944" | ||
| CMD="docker run --pull always --net=net-${{env.RELEASE_BRANCH_NAME}} jacogr/polkadot-js-tools:0.55.3 metadata ws://ref-node:9944 ws://test-node:9944" |
There was a problem hiding this comment.
If you specify "--pull always" to get the latest version, do you still need to specify 0.55.3?
There was a problem hiding this comment.
--pull always doesn't affect the version that gets pulled. It specifies to always pull the image regardless of whether or not the image is already cached locally.
mattheworris
approved these changes
Jun 15, 2023
shannonwells
pushed a commit
that referenced
this pull request
Apr 16, 2024
# Goal The goal of this PR is to upgrade the polkadotjs tools for metadata comparison. Closes #1230 This also includes PR #1601 for expediency. So also part of #1362 Ended up needing to run each one in a docker container with a new docker network. This allowed everything to talk correctly. # Checklist - [x] Tested with: make start + docker run --rm --platform=linux/amd64 --pull always jacogr/polkadot-js-tools:0.55.3 metadata wss://1.rpc.frequency.xyz ws://host.docker.internal:9944 - [x] Tested with test release Running: https://github.com/LibertyDSNP/frequency/actions/runs/5282806513 --------- Co-authored-by: Dmitri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The goal of this PR is to upgrade the polkadotjs tools for metadata comparison.
Closes #1230
This also includes PR #1601 for expediency. So also part of #1362
Ended up needing to run each one in a docker container with a new docker network. This allowed everything to talk correctly.
Checklist