[sofia-sip] fix issue 2283 by checking for SSL_ERROR_SSL and SSL_ERRO… #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…R_SYSCALL and avoiding socket i/o if so
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…R_SYSCALL and avoiding socket i/o if so
Also adds various error checks to make sure we always operate on a valid socket and sets a 5 second timeout on the SSL_write call in ws_close() to avoid waiting forever on something that isn't talking to us. Plus a check before SSL_read when the connection is marked down. There is one stray printf debug message left in this commit that should probably be turned into something more freeswitchish to log it somewhere better.