Skip to content

fix: add ref support to snackbar #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlanFnz merged 1 commit into from
Nov 28, 2024
Merged

fix: add ref support to snackbar #499

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 21 additions & 18 deletions src/components/experimental/Snackbar/Snackbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { ReactNode, type ReactElement } from 'react';
import React, { forwardRef, ReactNode, type ReactElement } from 'react';
import styled from 'styled-components';
import { SpaceProps, LayoutProps, PositionProps, FlexboxProps } from 'styled-system';

Expand Down Expand Up @@ -32,28 +32,31 @@ const DismissButton = styled(IconButton)`
padding: 0;
`;

interface SnackbarProps extends SpaceProps, LayoutProps, PositionProps, FlexboxProps {
interface SnackbarProps
extends SpaceProps,
LayoutProps,
PositionProps,
FlexboxProps,
React.HTMLAttributes<HTMLDivElement> {
children: ReactNode;
hasDismissButton?: boolean;
onDismiss?: () => void;
}

const Snackbar = ({
children,
hasDismissButton = false,
onDismiss = null,
...restProps
}: SnackbarProps): ReactElement => (
<Container {...restProps}>
{children}
{hasDismissButton && (
<DismissButton
data-testid="snackbar-close-icon"
Icon={() => <XCrossIcon size={24} color={getSemanticValue('inverse-on-surface')} />}
onPress={onDismiss}
/>
)}
</Container>
const Snackbar = forwardRef<HTMLDivElement, SnackbarProps>(
({ children, hasDismissButton = false, onDismiss = null, ...restProps }, ref): ReactElement => (
<Container ref={ref} {...restProps}>
{children}
{hasDismissButton && (
<DismissButton
data-testid="snackbar-close-icon"
Icon={() => <XCrossIcon size={24} color={getSemanticValue('inverse-on-surface')} />}
onPress={onDismiss}
aria-label="close"
/>
)}
</Container>
)
);

export { Snackbar, SnackbarProps };