-
Notifications
You must be signed in to change notification settings - Fork 27
feat(select): add value customisation #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I feel like this should be a configuration; i.e; we should have variants where this is possible and this is not possible (and would result in a validation error) depending on a config/prop value But for the sake of the dispatcher I am fine with merging, but this is in "wave" so we should probably have this option in the future imo |
What scenario do you have in mind? |
A normal scenario for a typeable select box component where we're only supposed to use the values available to us; that's how normal selects work, no? |
It still uses the values available in the items, this is just a presentation change for the selected item |
Respectfully I don't see the point in this change then; what are we trying to achieve? Can you add a more "real-life" example to the docs to illustrate where this is useful better? |
## [2.16.0](v2.15.1...v2.16.0) (2024-11-19) ### Features * **select:** add value customisation ([#492](#492)) ([982d7be](982d7be))
|
🎉 This PR is included in version 2.16.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |


What
Adds customisation ability for the Select value
Media
Why
Normally, select works like WYSIWYG: the user selects an item in the list and it is displayed as a select value
Scenario: we might show additional information in the list (Fleet label + fare + ETA), but still want to display only the label as the value, when the item is selected
How
Introducing the
renderValueprop