fix: add contract feature to freenet-stdlib dependency for ping app

[sanity]

fix: add contract feature to freenet-stdlib dependency for ping app

Why

The ping app's contract failed to compile because the contract feature
was not enabled on the freenet-stdlib dependency. This feature provides
freenet_stdlib::time::now() which is required by the ping contract.

This was preventing:

• Contract compilation at test time
• Local testing of partially connected network functionality
• Investigation of test failures described in test: fix 'channel closed' startup errors in partially connected network tests #2022

What Changed

Added contract feature to freenet-stdlib dependency in
apps/freenet-ping/types/Cargo.toml:

-freenet-stdlib = { workspace = true }
+freenet-stdlib = { workspace = true, features = ["contract"] }

Impact

• ✅ Ping contract now compiles successfully
• ✅ Enables local testing and development
• ✅ Unblocks investigation of test: fix 'channel closed' startup errors in partially connected network tests #2022 test failures
• ℹ️ Tests remain ignored pending resolution of CI-specific flakiness

Note on Test Status

While this fix enables the contract to compile, the partially connected
network tests remain ignored due to CI-specific flakiness discovered during
investigation. These tests pass locally but fail in CI with timing-related
issues (#2022, #2029).

The dependency fix is valuable on its own as it unblocks local testing
and development.

Related to #2022

🤖 Generated with Claude Code

Co-Authored-By: Claude [email protected]

[iduartgomez]

mmmm this depends upon who is compiling, so ti should be feature gated.

e.g. types is imported both in the app and in the contract itself, the first shouldn't not enable "contract" feature, the 2nd should do it.

[sanity]

@iduartgomez Good catch on the inline comment! You're absolutely right - the feature should be gated.

Looking at the code, freenet-ping-types/src/lib.rs already has proper feature gating:

#[cfg(feature = "std")]
let now = Utc::now();
#[cfg(not(feature = "std"))]
let now = freenet_stdlib::time::now();

So the types library only needs freenet_stdlib::time when building without std (i.e., when used by the contract).

The proper fix should be:

Option 1: Add a contract feature to freenet-ping-types that forwards to freenet-stdlib/contract:

# types/Cargo.toml
[features]
default = ["std"]
std = ["chrono/default"]
contract = ["freenet-stdlib/contract"]  # <-- add this

Then the contract crate enables it:

# contracts/ping/Cargo.toml
freenet-ping-types = { path = "../../types", default-features = false, features = ["contract"] }

Option 2: Check if PR #2031 (which modifies the test compilation pipeline) already handles this properly.

Looking at PR #2031, it adds extra_features() to the test harness which injects the contract feature during compilation. This might be a better approach since it keeps the feature propagation in the build tooling rather than requiring manual feature declarations.

Since #2031 handles this more comprehensively (fixes the handshake timeout issue + contract compilation), should I close this PR in favor of #2031, or would you prefer we implement Option 1 here?

[AI-assisted debugging and comment]

[iduartgomez]

If this was only added for that PR then yes, close this.

[sanity]

@iduartgomez Agreed - closing this PR.

PR #2031 handles the contract feature properly via the build tooling (extra_features() in the test harness), which is a better approach than unconditionally enabling it in the types crate.

Additionally, #2031 fixes the actual runtime issue (handshake timeout causing gateway crashes) that was the root cause of the CI failures.

This PR was useful for identifying the missing contract feature, but #2031 provides a more comprehensive and properly-architected solution.

[AI-assisted debugging and comment]