SF2935662 excepInfo not initialized so NULL check says not null and m…

…anipulates uninitialized data.
freemansoft · Nov 8, 2010 · 21d0ef6 · 21d0ef6
1 parent d94994e
commit 21d0ef6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/jacob/docs/ReleaseNotes.html b/jacob/docs/ReleaseNotes.html
@@ -32,6 +32,11 @@ <h3>Tracked Changes</h3>
     	checked on every object creation for users who run in the standard
     	<i>all classes in ROT</i> mode. (M2)</td>
   </tr>
+  <tr> 
+    <td width="13%" valign="top">2935662</td>
+    <td width="87%" valign="top">Error handling code crashes because of uninitialized data in Dispatch.cpp
+        Check for NULL fails. pfnDeferredFillIn pointer is not initialized, but it's not NULL.</td>
+  </tr>
   <tr> 
     <td width="13%" valign="top">&nbsp;</td>
     <td width="87%" valign="top">&nbsp;</td>

diff --git a/jacob/jni/Dispatch.cpp b/jacob/jni/Dispatch.cpp
@@ -418,6 +418,8 @@ JNIEXPORT jobject JNICALL Java_com_jacob_com_Dispatch_invokev
 {
   DISPPARAMS  dispparams;
   EXCEPINFO   excepInfo;
+  // Sourceforge Bug Tracker 2935662 uninitialized data can be not NULL with bad results
+  excepInfo.pfnDeferredFillIn = NULL;
 
   IDispatch *pIDispatch = extractDispatch(env, disp);
   if (!pIDispatch) return NULL;