Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(maybe_balance_style_tags): search further for missing tag #239

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

grossir
Copy link
Contributor

@grossir grossir commented Mar 7, 2025

Fixes #231

Allow searching beyond only whitespace for the missing style tag. This helps finding the missing tag when a party name or intro word ("see") are included in the style span. Added tests

Fixes #231

Allow searching beyond only whitespace for the missing space tag. This helps finding the missing tag when a party name or intro word "see") are included in the style span. Added tests
Copy link
Contributor

github-actions bot commented Mar 7, 2025

The Eyecite Report 👁️

Gains and Losses

There were 0 gains and 0 losses.

Click here to see details.
id Gain Loss

Time Chart

image

Generated Files

Branch 1 Output
Branch 2 Output
Full Output CSV

@flooie
Copy link
Contributor

flooie commented Mar 7, 2025

Can you include a test that illustrates the gain here?

@grossir
Copy link
Contributor Author

grossir commented Mar 7, 2025

@flooie check the modified test file, these 3 are gains that would not be annotated without this PR

        pairs = [
            (
                "it established in  <i>State v. Wingler</i> something",
                "Wingler</i>",
            ),
            ("something <em>See id.</em> at 642", "id.</em> at 642"),
            ("something <i>AT&T, supra</i> something", "supra</i>"),
        ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: PRs to Review
Development

Successfully merging this pull request may close these issues.

Improvements to maybe_balance_style_tags
2 participants