-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add endpoint for GSSAPI Authentication #88
Conversation
7f05e7d
to
33b9257
Compare
c9cc10d
to
78ef05b
Compare
48e90e9
to
8440492
Compare
Added a new field to the domain model, |
a883a81
to
6d871d3
Compare
6d871d3
to
6986cef
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I have tested the new end-points for IPA and AD use cases using the same curl calls:
curl -k -v -X POST --negotiate -u : https://bridge.ipa.test/bridge/login_kerberos/
curl -k -v -X POST https://bridge.ipa.test/bridge/login_password/ --data 'user=ipauser&password=Secret123'
I think the PR covers the initial feature for IPA and AD, and it can be easily extended later on to cover RHDS/LDAPwithKerberos.
Ref testing, we are enabling RedHatTrustedPipeline and the plan is to run extensive e2e tests there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added few in-line comments.
5ef3a5d
to
c796af2
Compare
Add the `login_kerberos` endpoint for handling GSSAPI authentications. mod_auth_gssapi and gssproxy are included as dependencies. Additional steps are included to the IPA domain addition, such as the addition of the HTTP service and keytab retrieval. Additionally, `login_password` endpoint is provided as well, which requests a ticket using the user and password passed with the client request. Signed-off-by: Antonio Torres <[email protected]>
c796af2
to
677065b
Compare
Added |
Add the
login_kerberos
endpoint for handling GSSAPI authentications. mod_auth_gssapi and gssproxy are included as dependencies. Additional steps are included to the IPA domain addition, such as the addition of the HTTP service and keytab retrieval. Additionally,login_password
endpoint is provided as well, which requests a ticket using the user and password passed with the client request.