-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: editorial team feedback changes part 1 #410
fix: editorial team feedback changes part 1 #410
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nirajn2311 Thank you so much for these fixes, and sorry for my late review.
2 requests:
-
When a text is turned into a link, could you change the popup to something like the one in the image below, so the user can edit or remove the link?
-
The top margin of headings is working perfect when the window (editor) is narrow, but when I resize it wider, another media query comes in and overrides the styles you added. Could you fix this too?
Everything else looks good 👍
Is it fine if the popup came on selecting the text coz I'm not sure if I'll be able to get it working for hover(have to confirm this) |
Yes, I think it's ok. It's better if we could keep the hover behavior so that authors can easily find it, but as long as we provide a way to edit/remove the link somehow, it's fine. |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
I got a menu to show up when you hover but the moment you move the cursor to the menu the damn thing keeps disappearing. I've been at it for 2 days now trying various methods, BubbleMenu(TipTap extension) and finally came to tippy.js (BubbleMenu uses this behind the scenes). IT'S FINALLY WORKING |
FINALLY ITS WORKING
@sidemt I've got the hover menu working for links so this PR is good for another review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's working perfectly. Thank you for all the fixes!
Checklist:
Update index.md
)Closes #393
Closes #391
Closes #402
The bubble menu can be modified to add more options. For now I've just added bold, italic and link options in it.