Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Qt documentation (6.8) #2462

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yellowmoneybank
Copy link

No description provided.

@yellowmoneybank yellowmoneybank requested a review from a team as a code owner March 20, 2025 10:12
@yellowmoneybank
Copy link
Author

Is there something I can do to get this merged?

@ClasherKasten
Copy link
Contributor

  1. There is an error with the scraper:
λ bundle exec thor docs:generate [email protected] --verbose --debug
/!\ WARNING /!\

Some scrapers send thousands of HTTP requests in a short period of time,
which can slow down the source site and trouble its maintainers.

Please scrape responsibly. Don't do it unless you're modifying the code.

To download the latest tested version of this documentation, run:
  thor docs:download [email protected]

Proceed? (y/n) y
Queue:   doc.qt.io/qt-6.8/index.html                                                                                                                                                                               
Queue:   doc.qt.io/qt-6.8/classes.html                                                                                                                                                                             
Queue:   doc.qt.io/qt-6.8/qmltypes.html                                                                                                                                                                            
Process: doc.qt.io/qt-6.8/index.html                                                                                                                                                                          [7ms]
ERROR:                                                                                                                                                                                                             
  https://doc.qt.io/qt-6.8/index.html
  Docs::ContainerFilter::ContainerNotFound: element '.main' could not be found in the document, url=https://doc.qt.io/qt-6.8/index.html

  /home/clasherkasten/workspace/devdocs/lib/docs/filters/core/container.rb:12:in 'Docs::ContainerFilter#call'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/instrumentable.rb:15:in 'Docs::Instrumentable::Methods#instrument'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/instrumentable.rb:15:in 'Docs::Instrumentable::Methods#instrument'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/scraper.rb:179:in 'Docs::Scraper#process_response'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/scraper.rb:160:in 'block in Docs::Scraper#handle_response'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/instrumentable.rb:15:in 'Docs::Instrumentable::Methods#instrument'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/scraper.rb:159:in 'Docs::Scraper#handle_response'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/scraper.rb:77:in 'block in Docs::Scraper#build_pages'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/requester.rb:59:in 'block (2 levels) in Docs::Requester#handle_response'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/requester.rb:58:in 'Array#each'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/requester.rb:58:in 'block in Docs::Requester#handle_response'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/instrumentable.rb:15:in 'Docs::Instrumentable::Methods#instrument'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/requester.rb:57:in 'Docs::Requester#handle_response'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/requester.rb:18:in 'Docs::Requester.run'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/scrapers/url_scraper.rb:38:in 'Docs::UrlScraper#request_all'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/scraper.rb:76:in 'Docs::Scraper#build_pages'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/doc.rb:115:in 'block in Docs::Doc.store_pages'
  /home/clasherkasten/workspace/devdocs/lib/docs/storage/abstract_store.rb:87:in 'block (2 levels) in Docs::AbstractStore#replace'
  /home/clasherkasten/workspace/devdocs/lib/docs/storage/abstract_store.rb:182:in 'Docs::AbstractStore#track_touched'
  /home/clasherkasten/workspace/devdocs/lib/docs/storage/abstract_store.rb:87:in 'block in Docs::AbstractStore#replace'
  /home/clasherkasten/workspace/devdocs/lib/docs/storage/abstract_store.rb:170:in 'Docs::AbstractStore#lock'
  /home/clasherkasten/workspace/devdocs/lib/docs/storage/abstract_store.rb:87:in 'Docs::AbstractStore#replace'
  /home/clasherkasten/workspace/devdocs/lib/docs/storage/abstract_store.rb:85:in 'block in Docs::AbstractStore#replace'
  /home/clasherkasten/workspace/devdocs/lib/docs/storage/abstract_store.rb:144:in 'Docs::AbstractStore#open_yield_close'
  /home/clasherkasten/workspace/devdocs/lib/docs/storage/abstract_store.rb:30:in 'Docs::AbstractStore#open'
  /home/clasherkasten/workspace/devdocs/lib/docs/storage/abstract_store.rb:85:in 'Docs::AbstractStore#replace'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/doc.rb:114:in 'Docs::Doc.store_pages'
  /home/clasherkasten/workspace/devdocs/lib/docs.rb:100:in 'Docs.generate'
  /home/clasherkasten/workspace/devdocs/lib/tasks/docs.thor:301:in 'Thor::Sandbox::DocsCLI#generate_doc'
  /home/clasherkasten/workspace/devdocs/lib/tasks/docs.thor:105:in 'Thor::Sandbox::DocsCLI#generate'

Process: doc.qt.io/qt-6.8/classes.html                                                                                                                                                                       [22ms]
ERROR:                                                                                                                                                                                                             
  https://doc.qt.io/qt-6.8/classes.html
  Docs::ContainerFilter::ContainerNotFound: element '.main' could not be found in the document, url=https://doc.qt.io/qt-6.8/classes.html

  /home/clasherkasten/workspace/devdocs/lib/docs/filters/core/container.rb:12:in 'Docs::ContainerFilter#call'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/instrumentable.rb:15:in 'Docs::Instrumentable::Methods#instrument'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/instrumentable.rb:15:in 'Docs::Instrumentable::Methods#instrument'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/scraper.rb:179:in 'Docs::Scraper#process_response'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/scraper.rb:160:in 'block in Docs::Scraper#handle_response'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/instrumentable.rb:15:in 'Docs::Instrumentable::Methods#instrument'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/scraper.rb:159:in 'Docs::Scraper#handle_response'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/scraper.rb:77:in 'block in Docs::Scraper#build_pages'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/requester.rb:59:in 'block (2 levels) in Docs::Requester#handle_response'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/requester.rb:58:in 'Array#each'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/requester.rb:58:in 'block in Docs::Requester#handle_response'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/instrumentable.rb:15:in 'Docs::Instrumentable::Methods#instrument'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/requester.rb:57:in 'Docs::Requester#handle_response'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/requester.rb:18:in 'Docs::Requester.run'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/scrapers/url_scraper.rb:38:in 'Docs::UrlScraper#request_all'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/scraper.rb:76:in 'Docs::Scraper#build_pages'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/doc.rb:115:in 'block in Docs::Doc.store_pages'
  /home/clasherkasten/workspace/devdocs/lib/docs/storage/abstract_store.rb:87:in 'block (2 levels) in Docs::AbstractStore#replace'
  /home/clasherkasten/workspace/devdocs/lib/docs/storage/abstract_store.rb:182:in 'Docs::AbstractStore#track_touched'
  /home/clasherkasten/workspace/devdocs/lib/docs/storage/abstract_store.rb:87:in 'block in Docs::AbstractStore#replace'
  /home/clasherkasten/workspace/devdocs/lib/docs/storage/abstract_store.rb:170:in 'Docs::AbstractStore#lock'
  /home/clasherkasten/workspace/devdocs/lib/docs/storage/abstract_store.rb:87:in 'Docs::AbstractStore#replace'
  /home/clasherkasten/workspace/devdocs/lib/docs/storage/abstract_store.rb:85:in 'block in Docs::AbstractStore#replace'
  /home/clasherkasten/workspace/devdocs/lib/docs/storage/abstract_store.rb:144:in 'Docs::AbstractStore#open_yield_close'
  /home/clasherkasten/workspace/devdocs/lib/docs/storage/abstract_store.rb:30:in 'Docs::AbstractStore#open'
  /home/clasherkasten/workspace/devdocs/lib/docs/storage/abstract_store.rb:85:in 'Docs::AbstractStore#replace'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/doc.rb:114:in 'Docs::Doc.store_pages'
  /home/clasherkasten/workspace/devdocs/lib/docs.rb:100:in 'Docs.generate'
  /home/clasherkasten/workspace/devdocs/lib/tasks/docs.thor:301:in 'Thor::Sandbox::DocsCLI#generate_doc'
  /home/clasherkasten/workspace/devdocs/lib/tasks/docs.thor:105:in 'Thor::Sandbox::DocsCLI#generate'

Process: doc.qt.io/qt-6.8/qmltypes.html                                                                                                                                                                      [23ms]
ERROR:                                                                                                                                                                                                             
  https://doc.qt.io/qt-6.8/qmltypes.html
  Docs::ContainerFilter::ContainerNotFound: element '.main' could not be found in the document, url=https://doc.qt.io/qt-6.8/qmltypes.html

  /home/clasherkasten/workspace/devdocs/lib/docs/filters/core/container.rb:12:in 'Docs::ContainerFilter#call'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/instrumentable.rb:15:in 'Docs::Instrumentable::Methods#instrument'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/instrumentable.rb:15:in 'Docs::Instrumentable::Methods#instrument'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/scraper.rb:179:in 'Docs::Scraper#process_response'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/scraper.rb:160:in 'block in Docs::Scraper#handle_response'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/instrumentable.rb:15:in 'Docs::Instrumentable::Methods#instrument'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/scraper.rb:159:in 'Docs::Scraper#handle_response'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/scraper.rb:77:in 'block in Docs::Scraper#build_pages'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/requester.rb:59:in 'block (2 levels) in Docs::Requester#handle_response'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/requester.rb:58:in 'Array#each'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/requester.rb:58:in 'block in Docs::Requester#handle_response'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/instrumentable.rb:15:in 'Docs::Instrumentable::Methods#instrument'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/requester.rb:57:in 'Docs::Requester#handle_response'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/requester.rb:18:in 'Docs::Requester.run'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/scrapers/url_scraper.rb:38:in 'Docs::UrlScraper#request_all'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/scraper.rb:76:in 'Docs::Scraper#build_pages'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/doc.rb:115:in 'block in Docs::Doc.store_pages'
  /home/clasherkasten/workspace/devdocs/lib/docs/storage/abstract_store.rb:87:in 'block (2 levels) in Docs::AbstractStore#replace'
  /home/clasherkasten/workspace/devdocs/lib/docs/storage/abstract_store.rb:182:in 'Docs::AbstractStore#track_touched'
  /home/clasherkasten/workspace/devdocs/lib/docs/storage/abstract_store.rb:87:in 'block in Docs::AbstractStore#replace'
  /home/clasherkasten/workspace/devdocs/lib/docs/storage/abstract_store.rb:170:in 'Docs::AbstractStore#lock'
  /home/clasherkasten/workspace/devdocs/lib/docs/storage/abstract_store.rb:87:in 'Docs::AbstractStore#replace'
  /home/clasherkasten/workspace/devdocs/lib/docs/storage/abstract_store.rb:85:in 'block in Docs::AbstractStore#replace'
  /home/clasherkasten/workspace/devdocs/lib/docs/storage/abstract_store.rb:144:in 'Docs::AbstractStore#open_yield_close'
  /home/clasherkasten/workspace/devdocs/lib/docs/storage/abstract_store.rb:30:in 'Docs::AbstractStore#open'
  /home/clasherkasten/workspace/devdocs/lib/docs/storage/abstract_store.rb:85:in 'Docs::AbstractStore#replace'
  /home/clasherkasten/workspace/devdocs/lib/docs/core/doc.rb:114:in 'Docs::Doc.store_pages'
  /home/clasherkasten/workspace/devdocs/lib/docs.rb:100:in 'Docs.generate'
  /home/clasherkasten/workspace/devdocs/lib/tasks/docs.thor:301:in 'Thor::Sandbox::DocsCLI#generate_doc'
  /home/clasherkasten/workspace/devdocs/lib/tasks/docs.thor:105:in 'Thor::Sandbox::DocsCLI#generate'

Failed!
  1. The way Qt 6.8 is introduced shadows the Qt 6.2 scraper (The version block without an explicit version):
λ bundle exec thor docs:generate qt --verbose --debug
/!\ WARNING /!\

Some scrapers send thousands of HTTP requests in a short period of time,
which can slow down the source site and trouble its maintainers.

Please scrape responsibly. Don't do it unless you're modifying the code.

To download the latest tested version of this documentation, run:
  thor docs:download qt

Proceed? (y/n) y
Queue:   doc.qt.io/qt-6.8/index.html                                                                                                                                                                               
Queue:   doc.qt.io/qt-6.8/classes.html                                                                                                                                                                             
Queue:   doc.qt.io/qt-6.8/qmltypes.html                                                                                                                                                                            
Process: doc.qt.io/qt-6.8/index.html                                                                                                                                                                          [6ms]
(The same error as before ...)
  1. Even when fixing the scraper, atleast the EntriesFilter is broken too (Didn't really look over the contents in depth, so i don't know if the CleanHtmlFilter is also broken):
    image
    image

(Note: Not a maintainer, so you still need to wait for someone with merge rights to review it, but fixing this before the maintainer review should help getting it merged, given there are no more bugs after that)

@yellowmoneybank
Copy link
Author

Thanks for the heads-up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants