-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add the GitHub action to create a Docker image and push to Docker Registry #2386
Conversation
Cool, thank you for woking on this feature. Some remarks:
@ojeytonwilliams, I would love to hear your thoughts on this PR. 😄
|
It looks like this is a good approach, but I noticed a couple of strange things. "Settings" → "Packages" doesn't seem to exist. Perhaps it won't until we publish the first one, I'm not sure. Branch protection rules don't seem relevant when we're running this via workflow dispatch or cron. Other than that (and what Simon pointed out), I think this all makes sense. |
@ojeytonwilliams I believe that setting change is not needed to be done. It should work out of the box.. @simon04 added the matrix option for the build image.. I believe the warning should go as well since added the option to not persist credentials. Updated the README as well. Let me know if these changes look good to y'all! Thanks for your comments! |
Great, thanks for confirming @chaitanyarahalkar @simon04 I'm happy with this if you are. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Let's give it a try. 😄
And there it is: https://github.com/freeCodeCamp/devdocs/pkgs/container/devdocs Cheers! |
This PR addresses #2330
Add automated Docker image builds
This PR adds a GitHub Actions workflow that automatically builds and publishes DevDocs Docker images to GitHub Container Registry (GHCR). The workflow addresses the concern of outdated official Docker images by providing fresh builds on a regular schedule.
What this adds:
New workflow .github/workflows/docker-build.yml that:
Runs monthly on the 1st of each month
Can be manually triggered via GitHub Actions UI
Builds both regular and Alpine-based images
Publishes to GHCR with the following tags:
The administrators for the repo would need to do the following -
I believe no other changes are needed here.