CLAP 1.2.3 #432

abique · 2024-11-18T17:45:26Z

No description provided.

* Add a description of the expectation of request_callback timing Without making a requirement, indicate the intent of the timing. * Add an apostrophe * Add host can starve feedback from alex * more review feedback * notjusthosts

per conversation on discord, oct 29

include/clap/ext/draft/location.h

baconpaul

Added some comments on the location extension.

include/clap/ext/draft/location.h

include/clap/ext/draft/scratch-memory.h

baconpaul · 2024-11-22T22:29:48Z

LGTM also.

messmerd

Some questions and suggestions regarding the location extension

include/clap/ext/draft/location.h

messmerd · 2024-11-24T19:55:10Z

How much information should a host provide to a plugin through the location extension? Should it provide all the information it can, or only information about the plugin itself?

abique · 2024-12-02T15:08:08Z

How much information should a host provide to a plugin through the location extension? Should it provide all the information it can, or only information about the plugin itself?

I'm not sure I understood well your question.

Think that you have a very large project, all you need to know your location is:
/project/track_group[0]/track[3]/device[6]

Here from the root track group, take the third track, then the 6th device and here we are.

Does that clarify the question?

comment refered to a previous version of the ambisonic extension.

abique · 2024-12-19T15:43:38Z

I've squashed some changes to the scratch-memory for max_concurrency_hint, and simplified the doc.

messmerd · 2025-01-16T19:19:41Z

@abique
Sorry it took so long for me to respond.

Think that you have a very large project, all you need to know your location is:
/project/track_group[0]/track[3]/device[6]

Okay, I was assuming that since the location API allows the host to tell the plugin its index within a parent element (i.e. in your example, the device is on the 3rd track), it could also provide information about other parts of the project structure which are not directly related to the plugin itself.

For example, if a plugin is the 2nd effect in an effects chain, could the location API provide information about the effects before it and after it in the chain?

I was assuming it could, since I don't see what the purpose is in telling a plugin it is the 2nd effect in the chain if it cannot also know what devices are the 1st and the 3rd.

But if I'm wrong about that, as it seems that I am based on your comment, that would explain my initial confusion about how the location API is supposed to provide that information. All location information would be as simple as your example - it can only provide the minimal amount of information needed to identify a device's location within the project tree, similar to a filesystem path.

messmerd

Should the undo, scratch-memory, location, and gain-reduction extensions be listed in the README alongside the other extensions?

include/clap/events.h

baconpaul · 2025-01-17T21:50:51Z

I had suggested on discord and I think alex agreed that gain_reduction may be better as gain_adjustment_display since

It is an adjustment (+ve and -ve values)
It is a display thing the plugin reports, not a gain adjuster that the host applies to the signal

If 'display' bugs people then gain_adjustment_reporting is also a good choice, for hosts which don't display it.

abique · 2025-01-17T21:52:27Z

Maybe I like gain_adjustment_reporting even more. 👍

abique · 2025-01-17T21:53:49Z

Should the undo, scratch-memory, location, and gain-reduction extensions be listed in the README alongside the other extensions?

We can wait for those to be stable.

ChangeLog.md

include/clap/all.h

baconpaul · 2025-01-17T21:53:08Z

include/clap/events.h

@@ -266,6 +271,12 @@ enum clap_transport_flags {
   CLAP_TRANSPORT_IS_WITHIN_PRE_ROLL = 1 << 7,
 };

+// clap_event_transport provides song position, tempo, and similar information
+// from the host to the plugin. There are two ways a host communicates these values.
+// In the `clap_process` structure sent to each processing block, the host must


I wrote must here, and I think that's right, but lets all be sure that we don't want a null transport in process to be valid. If a null transport in process is valid we should change this to 'may'

Or maybe 'may and is strongly encouraged to'

Transport is allowed to be null in the process struct, because some hosts may not have a transport, for example a mini host that runs a distortion effect in a guitar pedal.

Corrected in #443

include/clap/ext/draft/gain-reduction.h

schwaaa · 2025-01-18T13:17:32Z

Maybe I like gain_adjustment_reporting even more. 👍

I just saw this comment. Either way is fine with me, if you have a preference I'm happy to change it from the current gain_adjustment_display to gain_adjustment_reporting.

baconpaul · 2025-01-18T13:32:42Z

Maybe I like gain_adjustment_reporting even more. 👍

I just saw this comment. Either way is fine with me, if you have a preference I'm happy to change it from the current gain_adjustment_display to gain_adjustment_reporting.

After our (painful, long) conversation yesterday I think the best name is gain_adjustment_metering since this is the first metering extension we have (a metering extension is an extension where you grab a value on the audio thread with a functionally const double get function at the end of a process block, since alex didn't read the entire conversation, appropriately)

baconpaul · 2025-01-18T13:33:05Z

the conversation was painful and long because of me, by the way! Again sorry for that but I think we got a better result for it :)

basically expand some comments around ranges, meaning, and so on.

Co-authored-by: Dalton Messmer <[email protected]>

added zig bindings to language bindings section.

Co-authored-by: Alexandre Bique <[email protected]>

abique force-pushed the next branch 2 times, most recently from 773e346 to 069d784 Compare November 18, 2024 19:32

baconpaul and others added 3 commits November 18, 2024 20:35

Fix abort on delete plugin from track FX.

6f80a82

Document the special lifetime of clap_event_midi_sysex::buffer

851aa37

per conversation on discord, oct 29

abique force-pushed the next branch 2 times, most recently from fc4a9c3 to ab54bc5 Compare November 18, 2024 19:46

abique marked this pull request as ready for review November 18, 2024 19:46

abique requested review from baconpaul, robbert-vdh, Bremmers and defiantnerd November 18, 2024 19:47

abique self-assigned this Nov 18, 2024

messmerd reviewed Nov 19, 2024

View reviewed changes

include/clap/ext/draft/location.h Outdated Show resolved Hide resolved

baconpaul suggested changes Nov 19, 2024

View reviewed changes

include/clap/ext/draft/location.h Outdated Show resolved Hide resolved

include/clap/ext/draft/location.h Outdated Show resolved Hide resolved

include/clap/ext/draft/location.h Outdated Show resolved Hide resolved

abique force-pushed the next branch from 533e849 to 50f004f Compare November 19, 2024 08:51

p--b reviewed Nov 19, 2024

View reviewed changes

include/clap/ext/draft/scratch-memory.h Outdated Show resolved Hide resolved

defiantnerd approved these changes Nov 19, 2024

View reviewed changes

Bremmers approved these changes Nov 22, 2024

View reviewed changes

messmerd reviewed Nov 24, 2024

View reviewed changes

jatinchowdhury18 and others added 2 commits December 19, 2024 16:41

draft scratch-memory extension

1492e9e

remove erroneous comment in ambisonic.h

bdb1be4

comment refered to a previous version of the ambisonic extension.

abique force-pushed the next branch from 411bfa7 to fce70f0 Compare December 19, 2024 15:42

abique force-pushed the next branch from fce70f0 to de3907e Compare December 20, 2024 08:41

Draft location ext

1021004

abique force-pushed the next branch from de3907e to c279d5a Compare December 20, 2024 08:47

abique force-pushed the next branch from 4e95590 to 45f7cfd Compare January 17, 2025 11:49

messmerd reviewed Jan 17, 2025

View reviewed changes

include/clap/events.h Outdated Show resolved Hide resolved

baconpaul reviewed Jan 17, 2025

View reviewed changes

abique force-pushed the next branch 3 times, most recently from ab437e3 to 7087e88 Compare January 17, 2025 23:43

Add some of the feedback from the Auburn/DPlug port

0b3c73d

basically expand some comments around ranges, meaning, and so on.

abique force-pushed the next branch 2 times, most recently from 05fc5ff to 406a11c Compare January 20, 2025 17:12

schwaaa and others added 7 commits January 20, 2025 18:23

adding ext/draft/gain-adjustment-metering.h (#422, #440, #444)

abdffa7

Fix typo in include/clap/events.h

4c7a1ef

Co-authored-by: Dalton Messmer <[email protected]>

sort includes

c7c52fe

Add zig bindings to README.md

ec5ff0b

added zig bindings to language bindings section.

Adding Ada bindings to README.md (#441)

b23a520

Co-authored-by: Alexandre Bique <[email protected]>

Update ChangeLog

d3fe4e7

CLAP 1.2.3

b16e5f4

abique force-pushed the next branch from 16765e6 to b16e5f4 Compare January 20, 2025 17:27

abique merged commit 309d1da into main Jan 20, 2025
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CLAP 1.2.3 #432

CLAP 1.2.3 #432

abique commented Nov 18, 2024

baconpaul left a comment

baconpaul commented Nov 22, 2024

messmerd left a comment

messmerd commented Nov 24, 2024

abique commented Dec 2, 2024

abique commented Dec 19, 2024

messmerd commented Jan 16, 2025

messmerd left a comment

baconpaul commented Jan 17, 2025

abique commented Jan 17, 2025

abique commented Jan 17, 2025

baconpaul Jan 17, 2025

baconpaul Jan 17, 2025

abique Jan 17, 2025

baconpaul Jan 18, 2025

schwaaa commented Jan 18, 2025

baconpaul commented Jan 18, 2025

baconpaul commented Jan 18, 2025

CLAP 1.2.3 #432

CLAP 1.2.3 #432

Conversation

abique commented Nov 18, 2024

baconpaul left a comment

Choose a reason for hiding this comment

baconpaul commented Nov 22, 2024

messmerd left a comment

Choose a reason for hiding this comment

messmerd commented Nov 24, 2024

abique commented Dec 2, 2024

abique commented Dec 19, 2024

messmerd commented Jan 16, 2025

messmerd left a comment

Choose a reason for hiding this comment

baconpaul commented Jan 17, 2025

abique commented Jan 17, 2025

abique commented Jan 17, 2025

baconpaul Jan 17, 2025

Choose a reason for hiding this comment

baconpaul Jan 17, 2025

Choose a reason for hiding this comment

abique Jan 17, 2025

Choose a reason for hiding this comment

baconpaul Jan 18, 2025

Choose a reason for hiding this comment

schwaaa commented Jan 18, 2025

baconpaul commented Jan 18, 2025

baconpaul commented Jan 18, 2025