Fix indentation of end in function stubs written on separate lines - #227
Merged
Merged
Conversation
Function stubs such as
function f
end
were formatted with an indented `end` because the newline before the
`end` keyword was never tagged as pre-dedent in the empty-function
branch of `indent_function_or_macro`. Fixes #226.
Also, route the body-block branch of `indent_function_or_macro`
through `indent_keyword_block_end!`, the shared "tag keyword, indent
block, tag end" helper already used for loops, structs, do blocks and
modules, instead of duplicating it.
Assisted-by: Claude Code (Fable 5.1)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #227 +/- ##
==========================================
- Coverage 90.61% 90.60% -0.01%
==========================================
Files 9 9
Lines 4091 4088 -3
==========================================
- Hits 3707 3704 -3
Misses 384 384 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Function stubs such as
were formatted with an indented
endbecause the newline before theendkeyword was never tagged as pre-dedent in the empty-function branch ofindent_function_or_macro.Fixes #226.