Add tests for multiline callable struct signatures - #216
Draft
fredrikekre wants to merge 2 commits into
Draft
fredrikekre wants to merge 2 commits into
fredrikekre wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #216 +/- ##
===========================================
- Coverage 90.58% 46.36% -44.23%
===========================================
Files 9 8 -1
Lines 4080 4130 +50
===========================================
- Hits 3696 1915 -1781
- Misses 384 2215 +1831 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression tests for #153: a function signature with newlines inside the
callee parentheses parses as an anonymous function with a tuple body
instead of as a call, so the formatter split the
)(and broke thecode. Fixed upstream in JuliaSyntax#580.
Closes #153.