Skip to content

switch to files_upload_v2 and update version of slack_sdk to support it #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
morozgrafix wants to merge 2 commits into
base: master
Choose a base branch
from
Open

switch to files_upload_v2 and update version of slack_sdk to support it #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3240879
switch to files_upload_v2 and update version of slack_sdk to support it
morozgrafix Feb 13, 2025
16e7e66
bump plugin version to 2.2.1
morozgrafix Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion octoprint_Octoslack/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4821,6 +4821,8 @@ def upload_slack_asset(
upload_rsp = None
with open(local_file_path, "rb") as file_to_upload:
if slack_client2:
# Slack API method files.upload will be deprecated on March 11, 2025
# https://api.slack.com/changelog/2024-04-a-better-way-to-upload-files-is-here-to-stay
upload_rsp = slack_client2.api_call(
"files.upload",
channels=channels,
Expand All @@ -4829,7 +4831,7 @@ def upload_slack_asset(
file=file_to_upload,
)
elif slack_client3:
upload_rsp = slack_client3.files_upload(
upload_rsp = slack_client3.files_upload_v2(
channels=channels,
filename=dest_filename,
title=file_description,
Expand Down
4 changes: 2 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
plugin_name = "Octoslack"

# The plugin's version. Can be overwritten within OctoPrint's internal data via __plugin_version__ in the plugin module
plugin_version = "2.2.0"
plugin_version = "2.2.1"

# The plugin's description. Can be overwritten within OctoPrint's internal data via __plugin_description__ in the plugin
# module
Expand Down Expand Up @@ -59,7 +59,7 @@
plugin_requires.append("Pillow<7.0.0")
plugin_requires.append("humanize<=1.0.0")
else:
plugin_requires.append("slack_sdk>3.0.0")
plugin_requires.append("slack_sdk>3.23.0")
plugin_requires.append("minio")
plugin_requires.append("Pillow")
plugin_requires.append("humanize")
Expand Down