Skip to content

Fix start, stop, and restart #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vbotka
Copy link
Contributor

@vbotka vbotka commented Aug 30, 2021

  • Remove unused vars rc,out,_msg
  • Add {out} to success msg instead of {rc}
  • Stop jail if not down
  • Jail start, stop, and restart functions always return
    changed=True. Start if not up. Stop if not down. Restart without
    checking state (iocage util will start jail if down).

@vbotka
Copy link
Contributor Author

vbotka commented Aug 30, 2021

All tests passed. See the previous PR.

ANSIBLE_SHOW_CUSTOM_STATS=true ansible-playbook iocage_test.yml -M . -e my_hosts=test_23

CUSTOM STATS: **********************************************************************************
	test_23:   a1: Aug 31 00:57:06  a2: Aug 31 01:04:42  ok: 47

@xmj
Copy link
Member

xmj commented Aug 31, 2021

Changes lgtm 👍 but it now conflicts with what I've merved from #35 - could you please your changes on master branch?

You don't need to open a new pull request for this, just do git checkout master ; git pull origin master ; git checkout fix-start-stop ; git rebase -i master ; git push --force origin fix-start-stop or something along these lines

@vbotka
Copy link
Contributor Author

vbotka commented Aug 31, 2021

Changes lgtm but it now conflicts with what I've merved from #35 - could you please your changes on master branch?

Actually, I was able to resolve it online here. Thank you!

@xmj
Copy link
Member

xmj commented Aug 31, 2021

The reason I wanted you to rebase it is to not clutter the history with merges going from master into a feature branch, that will then get merged back into master again ;-)

@xmj
Copy link
Member

xmj commented Aug 31, 2021

@vbotka
Copy link
Contributor Author

vbotka commented Aug 31, 2021

The reason I wanted you to rebase it is to not clutter the history with merges going from master into a feature branch, that will then get merged back into master again ;-)

Done. (Thank you for the link!)

* Remove unused vars rc,out,_msg
* Add {out} to success msg instead of {rc}
* Stop jail if not down
* Test restarted state if not check_mode
* Jail start, stop, and restart functions always return
  changed=True. Start if not up. Stop if not down. Restart without
  checking state (iocage util will start jail if down).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants