complete general concepts questions#115
Open
angihe93 wants to merge 1 commit intofractal-nyc:mainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 9f5e141 in 1 minute and 18 seconds. Click for details.
- Reviewed
48lines of code in1files - Skipped
0files when reviewing. - Skipped posting
6draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. computer-science/general-concepts/answers/angi.md:16
- Draft comment:
Typo: 'calulating' should be 'calculating'. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% While this is technically a change since it's in a new file, pointing out typos is generally not valuable enough to warrant a PR comment. Typos should be caught by spellcheck tools, and even if they aren't, they don't impact the functionality or understanding of the content. This is a documentation file, not code. Maybe typos in documentation are more important than I think since they could confuse readers or make the content look unprofessional? While professionalism matters, this particular typo is very minor and obvious - no reader would be confused by "calulating" vs "calculating". The effort of making and reviewing the comment outweighs the benefit. This comment about a minor typo should be deleted as it's not important enough to warrant a PR comment.
2. computer-science/general-concepts/answers/angi.md:7
- Draft comment:
Standardize use of the abbreviation for 'for example' (e.g., instead of 'eg.'). - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%None
3. computer-science/general-concepts/answers/angi.md:16
- Draft comment:
Consider emphasizing the importance of a clear termination condition (base case) in recursion. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%None
4. computer-science/general-concepts/answers/angi.md:8
- Draft comment:
Expand the asynchronous handling explanation: include examples for languages (e.g., Go) in addition to Python. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%None
5. computer-science/general-concepts/answers/angi.md:27
- Draft comment:
Improve phrasing for anonymous functions. Consider rewording for clarity (e.g., '... often used as an argument to another function, such as providing a sorting rule'). - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%None
6. computer-science/general-concepts/answers/angi.md:16
- Draft comment:
Typo: 'calulating' should be 'calculating'. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% While this is technically a change since it's in a new file, spelling errors in documentation are very minor issues. They don't affect functionality and can be caught by spell checkers. The rules specifically say not to make obvious or unimportant comments. The typo could potentially confuse readers or make the documentation look unprofessional. Documentation quality is important. While documentation quality matters, this is such a minor spelling error that it's obvious what was meant. The rules explicitly state not to make obvious or unimportant comments. This comment should be deleted as it points out a trivial spelling error that doesn't meaningfully impact understanding of the documentation.
Workflow ID: wflow_7CF1pYmwU2lBd5KB
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Adds
angi.mdwith answers to general computer science questions, covering topics like async processing, recursion, and language choice.angi.mdundercomputer-science/general-concepts/answers/with answers to general computer science questions.This description was created by
for 9f5e141. You can customize this summary. It will automatically update as commits are pushed.