Open
Conversation
Contributor
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to c762630 in 2 minutes and 4 seconds. Click for details.
- Reviewed
95lines of code in1files - Skipped
0files when reviewing. - Skipped posting
6draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. computer-science/basics/answers/pabloRamirez.md:55
- Draft comment:
Format operator examples consistently; remove extraneous commas and ensure uniform punctuation. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative and suggests formatting changes without providing specific code suggestions or identifying potential issues. It doesn't align with the rules for useful comments.
2. computer-science/basics/answers/pabloRamirez.md:43
- Draft comment:
List examples with proper punctuation; consider adding a comma between 'stacks' and 'queues'. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% This is a new markdown file with answers to CS basics questions. The comment is technically correct about inconsistent punctuation, but it's an extremely minor formatting issue that doesn't affect understanding. The content and meaning are perfectly clear even without the comma. According to the rules, we should not make purely informative comments or unimportant suggestions. The inconsistent punctuation could make the text look unprofessional. Missing commas in lists is technically incorrect grammar. While technically correct, this is far too minor an issue to warrant a PR comment. The meaning is completely clear and this is just a markdown file with answers, not customer-facing documentation. Delete this comment as it's too minor and doesn't affect functionality or understanding.
3. computer-science/basics/answers/pabloRamirez.md:72
- Draft comment:
Capitalize the beginning of the sentence and use 'text-based' for consistency. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% While the comment is technically correct about capitalization and hyphenation, this is a student's answer file in markdown format. The content is clear and understandable despite these minor style issues. The comment doesn't point out any substantive problems with the technical content or understanding. The style improvements would make the text more professional. Consistent formatting helps with readability. However, these are very minor style issues in what appears to be a student assignment focused on understanding CS concepts. The substance is correct and clear. This comment should be deleted as it focuses on minor style issues rather than substantive problems with the content.
4. computer-science/basics/answers/pabloRamirez.md:31
- Draft comment:
Consider rephrasing 'renameable container' to 'container for storing values' for clarity. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%None
5. computer-science/basics/answers/pabloRamirez.md:43
- Draft comment:
Typo: In the answer for question 7, "stacks queues" may be missing a comma. Consider revising to "stacks, queues". - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% This is a new markdown file with answers to CS basics questions. The missing comma is a very minor formatting issue that doesn't affect readability significantly. The list is still understandable without the comma. This feels like an overly pedantic comment that doesn't meaningfully improve the code. The missing comma could technically be considered incorrect punctuation, and consistency in formatting is important for maintainability. While correct punctuation is good, this is a very minor issue in an educational answer file, not production code. The comment adds more noise than value. This comment should be deleted as it's too minor and doesn't meaningfully improve the content.
6. computer-science/basics/answers/pabloRamirez.md:72
- Draft comment:
Typo: In the answer for question 12, the sentence after the period starts with a lowercase letter "it". It should be capitalized as "It". - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% While technically correct, this is an extremely minor grammatical issue in what appears to be a student's homework or practice answers. The rules specifically say not to make obvious or unimportant comments. Grammar nitpicks like this don't affect code quality or functionality. Perhaps maintaining consistent and professional documentation is important for readability and learning purposes? While good documentation is important, this level of nitpicking on student practice work creates noise and doesn't meaningfully improve the content's usefulness or understanding. This comment should be deleted as it's too minor and doesn't meaningfully improve the content.
Workflow ID: wflow_Yz3zmxGa4z4Q41Ks
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
| 14. What are calculations (e.g. “pure functions”)? | ||
|
|
||
| answer14.) | ||
| idk ngl |
Contributor
There was a problem hiding this comment.
Replace placeholder 'idk ngl' with a formal explanation of pure functions.
Suggested change
| idk ngl | |
| A pure function always returns the same output for the same input and does not cause any side effects. |
| 15. What are actions (e.g. “side-effectful functions”)? | ||
|
|
||
| answer15.) | ||
| idk ngl lol |
Contributor
There was a problem hiding this comment.
Replace 'idk ngl lol' with a detailed, professional explanation of side-effectful functions.
Suggested change
| idk ngl lol | |
| Actions (side-effectful functions) are functions that interact with the outside world or change state, such as modifying a variable, updating a database, or printing to the screen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added answers to the Computer Science Basics section under computer-science/basics/answers/pabloRamirez.md.
Important
Adds
pabloRamirez.mdwith answers to basic CS questions incomputer-science/basics/answers/, covering fundamental concepts and placeholders for advanced topics.pabloRamirez.mdtocomputer-science/basics/answers/with answers to basic CS questions.This description was created by
for c762630. You can customize this summary. It will automatically update as commits are pushed.