Skip to content

completed light networking section#102

Open
guy-car wants to merge 1 commit intofractal-nyc:mainfrom
guy-car:guillaume-caron/light-networking
Open

completed light networking section#102
guy-car wants to merge 1 commit intofractal-nyc:mainfrom
guy-car:guillaume-caron/light-networking

Conversation

@guy-car
Copy link
Copy Markdown

@guy-car guy-car commented May 30, 2025

Important

Adds guillaume.md with answers to basic networking questions in computer-science/light-networking/answers/.

  • Documentation:
    • Adds guillaume.md to computer-science/light-networking/answers/ with answers to networking questions.
    • Explains IP addresses, HTTP vs HTTPS, URLs, and DNS.

This description was created by Ellipsis for 12dd941. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Copy Markdown
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 12dd941 in 1 minute and 4 seconds. Click for details.
  • Reviewed 15 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. computer-science/light-networking/answers/guillaume.md:8
  • Draft comment:
    Add a newline at the end of the file for POSIX compliance.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50% Missing trailing newlines can cause issues with some tools and is generally considered good practice. However, this is a very minor issue that would likely be caught by linters or formatting tools. The file is also just a markdown file with answers, not source code where POSIX compliance would be more critical. The comment is technically correct, but is it important enough to warrant a PR comment? Most modern editors and tools handle this automatically. While minor, the fix is very simple and clear, and it's a good practice to maintain across all text files regardless of content type. Given that this is a minor formatting issue that would likely be caught by automated tools, and doesn't impact functionality, we should remove this comment.
2. computer-science/light-networking/answers/guillaume.md:1
  • Draft comment:
    Consider using markdown headers for questions to enhance clarity.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_ec9UoPk6DW2jwkCT

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant