Update to newer coding standards. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated __init__.py to use absolute imports. https://docs.python.org/2.5/whatsnew/pep-328.html This will allow it to be imported in Python 3. Updated BrotherPrint class to be new style. https://wiki.python.org/moin/NewClassVsClassicClass
|
Kyle, thanks for brother print library. I was playing around with it and noticed it could use some very small updates. |
I know it's minor and petty but it a lot easier to work on in an IDE if it's PEP8.
Along with that I did a bunch of PEP8 cleanup. Normally I would have used a seperate commit but I couldn't get git cola to do a line by line commit for me. :-(
daeta
pushed a commit
to daeta/python-brotherprint
that referenced
this pull request
Jun 25, 2020
Revert "Delete unnecessary import"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated init.py to use absolute imports.
https://docs.python.org/2.5/whatsnew/pep-328.html
This will allow it to be imported in Python 3.
Updated BrotherPrint class to be new style.
https://wiki.python.org/moin/NewClassVsClassicClass