Add provenance attestation when publishing to NPM #725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snosenzo
approved these changes
Apr 8, 2024
| - run: yarn workspace @foxglove/${{ matrix.package }} pack | ||
| - name: Publish to NPM (dry run) | ||
| if: ${{ matrix.node-version == '18.x' }} | ||
| # `yarn publish` does not support --provenance |
There was a problem hiding this comment.
you linked to the yarn berry issue in the mcap repo, would be good to have it here too:
yarnpkg/berry#5430
There was a problem hiding this comment.
This repo isn’t using berry for better or worse
There was a problem hiding this comment.
I think you can drop this yarn comment altogether. It isn't crazy that to publish to a repository you use the tool made by that repository.
There was a problem hiding this comment.
I will keep the comment since I think the yarn pack && npm publish package.tgz is a bit unusual otherwise and I would wonder why it's being done this way.
defunctzombie
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
None
Description
This adds a provenance attestation to the published package so consumers can verify that the package was built on GitHub Actions:
The package will appear like this on npm:
Also fixes an error when publishing due to trying to publish the same package twice (with different node versions).