Skip to content

Feat/8293 #8422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Feat/8293 #8422

wants to merge 5 commits into from

Conversation

tsnewnami
Copy link
Contributor

Closes #8293

Motivation

Solution

@tsnewnami
Copy link
Contributor Author

Hey @mattsse, could I please ask for help on the following 2 questions:

  1. Feedback on this approach of creating another method. This was to avoid the use of interior mutability which would've allowed for mutation under a &self API. Introducing interior mutability seemed like a much larger and riskier uplift.
  2. I would also appreciate any insights on why this particular test fails at https://github.com/EdwardJES/foundry/blob/cd56aa00c8fa4fbab452efa3751bbf58d89b806e/crates/anvil/src/eth/backend/mem/storage.rs#L565, where the acc can't be found.

Thank you very much.

@tsnewnami tsnewnami closed this Jul 15, 2024
@tsnewnami tsnewnami deleted the feat/8293 branch July 15, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(anvil): improve historic state access
1 participant