feat(forge/script): decode execution traces when --json is enabled
#10109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xpanoramix
requested review from
DaniPopes,
klkvr,
mattsse and
grandizzy
as code owners
DaniPopes
requested changes
Apr 29, 2025
crates/script/src/execute.rs
Outdated
| decode_trace_arena(trace, decoder).await?; | ||
| } | ||
|
|
||
| let result_with_decoded_traces = &ScriptResult { |
There was a problem hiding this comment.
please add a #[derive(Clone)] to ScriptResult, clone it and then modify result.traces directly
There was a problem hiding this comment.
Thanks, changed in 8f6d3b9.
|
Thanks, just one nit. Sorry for the late review. |
Signed-off-by: 0xpanoramix <[email protected]>
Signed-off-by: 0xpanoramix <[email protected]>
Signed-off-by: 0xpanoramix <[email protected]>
Signed-off-by: 0xpanoramix <[email protected]>
Signed-off-by: 0xpanoramix <[email protected]>
Signed-off-by: 0xpanoramix <[email protected]>
0xpanoramix
force-pushed
the
0xpanoramix/decode-traces-for-json-script-output
branch
from
5390c66 to
a2cc43b
Compare
zerosnacks
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR resolves #10019.
More precisely, it ensures that the execution traces are decoded when the
--jsonflag is enabled for theforge scriptcommand.With those changes, the command prints all the decoded values and not just
null.Solution
I forced the decoding of the traces after the execution has completed, right before the result object is encoded in JSON and printing to the stdout.
Note: I updated the existing CLI test.
PR Checklist