chore: remove a bunch of unnecessary #[inline] (#11397)

Author: DaniPopes

crates/anvil/src/eth/backend/mem/inspector.rs

@@ -175,7 +175,6 @@ where
         }
     }
 
-    #[inline]
     fn selfdestruct(&mut self, contract: Address, target: Address, value: U256) {
         call_inspectors!([&mut self.tracer, &mut self.transfer], |inspector| {
             Inspector::<CTX, EthInterpreter>::selfdestruct(inspector, contract, target, value)

crates/cheatcodes/spec/src/cheatcode.rs

@@ -141,7 +141,6 @@ impl Group {
     ///
     /// Some groups are inherently safe or unsafe, while others are ambiguous and will return
     /// `None`.
-    #[inline]
     pub const fn safety(self) -> Option<Safety> {
         match self {
             Self::Evm | Self::Testing => None,
@@ -158,7 +157,6 @@ impl Group {
     }
 
     /// Returns this value as a string.
-    #[inline]
     pub const fn as_str(self) -> &'static str {
         match self {
             Self::Evm => "evm",
@@ -192,7 +190,6 @@ pub enum Safety {
 
 impl Safety {
     /// Returns this value as a string.
-    #[inline]
     pub const fn as_str(self) -> &'static str {
         match self {
             Self::Safe => "safe",
@@ -201,7 +198,6 @@ impl Safety {
     }
 
     /// Returns whether this value is safe.
-    #[inline]
     pub const fn is_safe(self) -> bool {
         matches!(self, Self::Safe)
     }

crates/cheatcodes/spec/src/function.rs

@@ -64,7 +64,6 @@ impl fmt::Display for Visibility {
 
 impl Visibility {
     /// Returns the string representation of the visibility.
-    #[inline]
     pub const fn as_str(self) -> &'static str {
         match self {
             Self::External => "external",
@@ -99,7 +98,6 @@ impl fmt::Display for Mutability {
 
 impl Mutability {
     /// Returns the string representation of the mutability.
-    #[inline]
     pub const fn as_str(self) -> &'static str {
         match self {
             Self::Pure => "pure",

crates/cheatcodes/src/error.rs

@@ -142,7 +142,6 @@ impl Error {
     }
 
     /// Returns the kind of this error.
-    #[inline]
     pub fn kind(&self) -> ErrorKind<'_> {
         let data = self.data();
         if self.is_str {
@@ -154,38 +153,31 @@ impl Error {
     }
 
     /// Returns the raw data of this error.
-    #[inline]
     pub fn data(&self) -> &[u8] {
         unsafe { &*self.data }
     }
 
     /// Returns `true` if this error is a human-readable string.
-    #[inline]
     pub fn is_str(&self) -> bool {
         self.is_str
     }
 
-    #[inline]
     fn new_str(data: &'static str) -> Self {
         Self::_new(true, false, data.as_bytes())
     }
 
-    #[inline]
     fn new_string(data: String) -> Self {
         Self::_new(true, true, Box::into_raw(data.into_boxed_str().into_boxed_bytes()))
     }
 
-    #[inline]
     fn new_bytes(data: &'static [u8]) -> Self {
         Self::_new(false, false, data)
     }
 
-    #[inline]
     fn new_vec(data: Vec<u8>) -> Self {
         Self::_new(false, true, Box::into_raw(data.into_boxed_slice()))
     }
 
-    #[inline]
     fn _new(is_str: bool, drop: bool, data: *const [u8]) -> Self {
         debug_assert!(!data.is_null());
         Self { is_str, drop, data }
@@ -249,7 +241,6 @@ impl From<Vec<u8>> for Error {
 }
 
 impl From<Bytes> for Error {
-    #[inline]
     fn from(value: Bytes) -> Self {
         Self::new_vec(value.into())
     }

crates/cheatcodes/src/inspector.rs

@@ -195,7 +195,6 @@ impl Clone for TestContext {
 
 impl TestContext {
     /// Clears the context.
-    #[inline]
     pub fn clear(&mut self) {
         self.opened_read_files.clear();
     }
@@ -1049,7 +1048,6 @@ impl Cheatcodes {
 }
 
 impl Inspector<EthEvmContext<&mut dyn DatabaseExt>> for Cheatcodes {
-    #[inline]
     fn initialize_interp(&mut self, interpreter: &mut Interpreter, ecx: Ecx) {
         // When the first interpreter is initialized we've circumvented the balance and gas checks,
         // so we apply our actual block data with the correct fees and all.

crates/cheatcodes/src/lib.rs

@@ -99,12 +99,10 @@ pub(crate) trait DynCheatcode: 'static + std::fmt::Debug {
 }
 
 impl<T: Cheatcode> DynCheatcode for T {
-    #[inline]
     fn cheatcode(&self) -> &'static spec::Cheatcode<'static> {
         Self::CHEATCODE
     }
 
-    #[inline]
     fn dyn_apply(&self, ccx: &mut CheatsCtxt, executor: &mut dyn CheatcodesExecutor) -> Result {
         self.apply_full(ccx, executor)
     }
@@ -157,12 +155,10 @@ impl std::ops::DerefMut for CheatsCtxt<'_, '_, '_, '_> {
 }
 
 impl CheatsCtxt<'_, '_, '_, '_> {
-    #[inline]
     pub(crate) fn ensure_not_precompile(&self, address: &Address) -> Result<()> {
         if self.is_precompile(address) { Err(precompile_error(address)) } else { Ok(()) }
     }
 
-    #[inline]
     pub(crate) fn is_precompile(&self, address: &Address) -> bool {
         self.ecx.journaled_state.warm_addresses.precompiles().contains(address)
     }

crates/cli/src/utils/mod.rs

@@ -319,12 +319,10 @@ pub struct Git<'a> {
 }
 
 impl<'a> Git<'a> {
-    #[inline]
     pub fn new(root: &'a Path) -> Self {
         Self { root, quiet: shell::is_quiet(), shallow: false }
     }
 
-    #[inline]
     pub fn from_config(config: &'a Config) -> Self {
         Self::new(config.root.as_path())
     }
@@ -389,18 +387,15 @@ impl<'a> Git<'a> {
             .map(drop)
     }
 
-    #[inline]
     pub fn root(self, root: &Path) -> Git<'_> {
         Git { root, ..self }
     }
 
-    #[inline]
     pub fn quiet(self, quiet: bool) -> Self {
         Self { quiet, ..self }
     }
 
     /// True to perform shallow clones
-    #[inline]
     pub fn shallow(self, shallow: bool) -> Self {
         Self { shallow, ..self }
     }

crates/common/fmt/src/dynamic.rs

@@ -104,14 +104,12 @@ struct DynValueDisplay<'a> {
 
 impl<'a> DynValueDisplay<'a> {
     /// Creates a new [`Display`](fmt::Display) wrapper for the given value.
-    #[inline]
     fn new(value: &'a DynSolValue, raw: bool) -> Self {
         Self { value, formatter: DynValueFormatter { raw } }
     }
 }
 
 impl fmt::Display for DynValueDisplay<'_> {
-    #[inline]
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         self.formatter.value(self.value, f)
     }

crates/common/fmt/src/exp.rs

@@ -15,7 +15,6 @@ use yansi::Paint;
 ///     1234124124 -> 1.23e9
 ///     10000000 -> 1e7
 /// ```
-#[inline]
 pub fn to_exp_notation(value: U256, precision: usize, trim_end_zeros: bool, sign: Sign) -> String {
     let stringified = value.to_string();
     let exponent = stringified.len() - 1;

crates/common/src/calc.rs

@@ -1,7 +1,6 @@
 //! Commonly used calculations.
 
 /// Returns the mean of the slice.
-#[inline]
 pub fn mean(values: &[u64]) -> u64 {
     if values.is_empty() {
         return 0;
@@ -11,7 +10,6 @@ pub fn mean(values: &[u64]) -> u64 {
 }
 
 /// Returns the median of a _sorted_ slice.
-#[inline]
 pub fn median_sorted(values: &[u64]) -> u64 {
     if values.is_empty() {
         return 0;