chore(cheatocodes): remove as_debug (#11395)

Upcasting was stabilized since then, so we can just add it as a super trait.

Author: DaniPopes

crates/cheatcodes/src/inspector.rs

@@ -2400,7 +2400,7 @@ fn apply_dispatch(
     let cheat = calls_as_dyn_cheatcode(calls);
 
     let _guard = debug_span!(target: "cheatcodes", "apply", id = %cheat.id()).entered();
-    trace!(target: "cheatcodes", cheat = ?cheat.as_debug(), "applying");
+    trace!(target: "cheatcodes", ?cheat, "applying");
 
     if let spec::Status::Deprecated(replacement) = *cheat.status() {
         ccx.state.deprecated.insert(cheat.signature(), replacement);

crates/cheatcodes/src/lib.rs

@@ -92,11 +92,9 @@ pub(crate) trait Cheatcode: CheatcodeDef + DynCheatcode {
     }
 }
 
-pub(crate) trait DynCheatcode: 'static {
+pub(crate) trait DynCheatcode: 'static + std::fmt::Debug {
     fn cheatcode(&self) -> &'static spec::Cheatcode<'static>;
 
-    fn as_debug(&self) -> &dyn std::fmt::Debug;
-
     fn dyn_apply(&self, ccx: &mut CheatsCtxt, executor: &mut dyn CheatcodesExecutor) -> Result;
 }
 
@@ -106,11 +104,6 @@ impl<T: Cheatcode> DynCheatcode for T {
         Self::CHEATCODE
     }
 
-    #[inline]
-    fn as_debug(&self) -> &dyn std::fmt::Debug {
-        self
-    }
-
     #[inline]
     fn dyn_apply(&self, ccx: &mut CheatsCtxt, executor: &mut dyn CheatcodesExecutor) -> Result {
         self.apply_full(ccx, executor)