-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add v2 verify routes #73
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty, smol nits and suggestions
#[derive(Clone, Debug, PartialEq, Copy)] | ||
pub enum EtherscanApiVersion { | ||
V1, | ||
V2, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs doc oneliner
@@ -99,6 +107,15 @@ impl Client { | |||
Client::builder().with_api_key(api_key).chain(chain)?.build() | |||
} | |||
|
|||
pub fn new_v2_from_env(chain: Chain) -> Result<Self> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs
/// Etherscan API version (v2 is new verifier version) | ||
etherscan_api_version: Option<EtherscanApiVersion>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can remove this option and use v1 as the default
standard-json-input
integration testsThis is a prerequisite PR for foundry-rs/foundry#9196
Notes: