Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add universal-sierra-compiler dependency #1

Merged
merged 4 commits into from
Jan 10, 2024

Conversation

war-in
Copy link
Contributor

@war-in war-in commented Jan 5, 2024

Universal Sierra Compiler will be installed now

@war-in war-in requested review from THenry14 and piotmag769 January 5, 2024 13:36
@war-in war-in self-assigned this Jan 5, 2024
@war-in war-in changed the title Add universal-sierra-compiler dependency build: Add universal-sierra-compiler dependency Jan 5, 2024
Copy link

@THenry14 THenry14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's mark as draft until this can be merged 👍

@war-in war-in marked this pull request as draft January 5, 2024 13:59
@war-in
Copy link
Contributor Author

war-in commented Jan 5, 2024

I've done the installation script like the snfoundryup installation script, but it seems that there is a problem with the ubuntu shell. Any thoughts?
https://github.com/foundry-rs/asdf-starknet-foundry/actions/runs/7422540402/job/20198042799?pr=1#step:2:54

@THenry14
Copy link

THenry14 commented Jan 5, 2024

I've done the installation script like the snfoundryup installation script, but it seems that there is a problem with the ubuntu shell. Any thoughts? https://github.com/foundry-rs/asdf-starknet-foundry/actions/runs/7422540402/job/20198042799?pr=1#step:2:54

My bet is that the shell there is either sh or maybe even some kind of noshell. If it's the former, we probably don't have it in install script

@war-in
Copy link
Contributor Author

war-in commented Jan 5, 2024

I've done the installation script like the snfoundryup installation script, but it seems that there is a problem with the ubuntu shell. Any thoughts? https://github.com/foundry-rs/asdf-starknet-foundry/actions/runs/7422540402/job/20198042799?pr=1#step:2:54

My bet is that the shell there is either sh or maybe even some kind of noshell. If it's the former, we probably don't have it in install script

Do you think we should care then?

@THenry14
Copy link

THenry14 commented Jan 5, 2024

I've done the installation script like the snfoundryup installation script, but it seems that there is a problem with the ubuntu shell. Any thoughts? https://github.com/foundry-rs/asdf-starknet-foundry/actions/runs/7422540402/job/20198042799?pr=1#step:2:54

My bet is that the shell there is either sh or maybe even some kind of noshell. If it's the former, we probably don't have it in install script

Do you think we should care then?

for sh, probably yes - I'd just add it to the install script and call it a day. for others not so much.

@war-in war-in requested a review from THenry14 January 5, 2024 14:36
Copy link

@THenry14 THenry14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after branch is changed, this is mergeable

@war-in war-in marked this pull request as ready for review January 10, 2024 15:01
@war-in war-in merged commit cde9359 into main Jan 10, 2024
6 checks passed
@war-in war-in deleted the war-in/add-universal-sierra-complier-dependency branch January 10, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants