fix(targets): make tag subcommand deny empty tags #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you go ahead and add a separate commit to fix the CI issue? I know its not your problem but would be good to fix it while we are doing thins. |
vkhoroz
reviewed
Feb 13, 2025
subcommands/targets/tag.go
Outdated
| @@ -78,6 +78,8 @@ func doTag(cmd *cobra.Command, args []string) { | |||
| targetTags := tags | |||
| if tagAppend { | |||
| targetTags = Set(custom.Tags, tags) | |||
| } else if len(targetTags) == 0 { | |||
| subcommands.DieNotNil(fmt.Errorf("Cannot change tags from %s -> %s. Empty values are not allowed.", custom.Tags, targetTags)) | |||
There was a problem hiding this comment.
I'm wondering why do we make this check here?
Wouldn't it be easier and better to check if len(tags) == 0 { errorOut } at line 60?
Or maybe just set something like the minlength in cobra argument definition?
StealthyCoder
force-pushed
the
fix/targets_tag
branch
from
8cfc6ff to
98c0623
Compare
vkhoroz
approved these changes
Mar 12, 2025
StealthyCoder
force-pushed
the
fix/targets_tag
branch
from
98c0623 to
5a1f529
Compare
Signed-off-by: Eric Bode <[email protected]>
StealthyCoder
force-pushed
the
fix/targets_tag
branch
from
5a1f529 to
992c231
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will not allow the user to potentially shoot themselves in the foot by denying potential empty tags list.