-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove deprecated push_to_hub_token to resolve warning #419
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Luka Dojcinovic <[email protected]>
Thanks for making a pull request! 😃 |
Because of this change, also had to change how the field names are obtained from SFTConfig. Signed-off-by: Luka Dojcinovic <[email protected]>
Summary of changes made with 9e567e2 It seems that using .to_dict() method on Because of the change to In summary, the changes to
All code has passed Please let me know your thoughts, thank you. |
Signed-off-by: Luka Dojcinovic <[email protected]>
Description of the change
Running tuning locally produces this warning message:
When I print out the
transformer_kwargs
dictionary, I can see that bothhub_token
andpush_to_hub_token
are in the dictionary. Here is a snippet of it.I made a temporary fix by simply popping
push_to_hub_token
out of the dictionary and now the warning is gone.I am wondering if anyone knows where
push_to_hub_token
is originating from or best way to remove it.Related issue number
Issue #1205
How to verify the PR
Run tuning locally: